Skip to content

Block support: Preserve anchor value in comment delimiter #70993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 11 commits into from
Dec 16, 2025
Merged

Block support: Preserve anchor value in comment delimiter #70993

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e3c3cae
Block support: Preserve anchor value in comment delimiter
t-hamano Jul 31, 2025
f3ca9ea
Fix some unit tests
t-hamano Jul 31, 2025
ff9b63a
Fix one unit test
t-hamano Jul 31, 2025
047167c
Don't save falsy value
t-hamano Jul 31, 2025
9e9985c
Don't preserve empty anchor when transforming from Spacer block to Se…
t-hamano Jul 31, 2025
5cca67b
Don't preserve empty anchor when transforming from Separator block to…
t-hamano Jul 31, 2025
c96f0ee
Try to fix mobile unit test
t-hamano Jul 31, 2025
862a7ea
Merge branch 'trunk' into update-anchor-support
t-hamano Sep 12, 2025
fb80a2d
Regenerate fixtures
t-hamano Sep 12, 2025
f441b07
Merge branch 'trunk' into update-anchor-support
t-hamano Oct 13, 2025
ab91b70
Merge branch 'trunk' into update-anchor-support
t-hamano Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix some unit tests
  • Loading branch information
@t-hamano
t-hamano committed Jul 31, 2025
commit f3ca9eaff3dcd1260f3b0856925f4aa47e97053e
2 changes: 1 addition & 1 deletion packages/block-editor/src/hooks/test/__snapshots__/anchor.native.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`anchor should set the ID attribute on the block 1`] = `
"<!-- wp:paragraph -->
"<!-- wp:paragraph {"anchor":"my-anchor"} -->
<p id="my-anchor"></p>
<!-- /wp:paragraph -->"
`;
4 changes: 2 additions & 2 deletions test/integration/fixtures/blocks/core__group__deprecated.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"attributes": {
"tagName": "div",
"align": "full",
"anchor": "test-id",
"backgroundColor": "lighter-blue"
"backgroundColor": "lighter-blue",
"anchor": "test-id"
},
"innerBlocks": [
{
Expand Down
2 changes: 1 addition & 1 deletion test/integration/fixtures/blocks/core__group__deprecated.serialized.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:group {"align":"full","backgroundColor":"lighter-blue"} -->
<!-- wp:group {"align":"full","anchor":"test-id","backgroundColor":"lighter-blue"} -->
<div class="wp-block-group alignfull has-lighter-blue-background-color has-background" id="test-id"><!-- wp:paragraph -->
<p>test</p>
<!-- /wp:paragraph --></div>
Expand Down
Loading