Block Variation Transforms: Add box-sizing rule #71052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
requested review from
aaronrobertshaw,
ramonjd,
talldan and
tellthemachines
andrewserong
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +4 B (0%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Aug 5, 2025
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
I can't reproduce the effect in this PR, but I applied box-sizing: border-box; to .block-editor-block-variation-transforms and could see no visible regression. The changes in itself makes sense.
The rule was being overwritten by the following in my testing:
Contributor
Author
|
Thanks for the quick review @ramonjd!
Yes, that's expected — I mightn't have made it clear enough in my testing instructions! This is more of a code quality fix than a bug fix, as the issue isn't present in Gutenberg (but rather, if you're using this component in an environment that doesn't already provide the |
|
Flaky tests detected in 2263c13. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16738578974
|
andrewserong
deleted the
update/block-editor-variation-transforms-box-sizing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Semi-related to: #70684
This is a similar kind of PR to a couple of my earlier ones at trying to ensure that block editor components are responsible for their own dependencies. After fixing
fieldsets in #70685, I noticed that the block variation transforms components (i.e. the switcher in the right hand sidebar for the Group block) expects a globalbox-sizingrule in order to prevent a horizontal scrollbar from happening.This tiny PR seeks to make sure that the block variation transforms component is responsible for its own sizing.
Why?
To ensure that (similar to the components library) block editor components are taking care of their own resets / aren't so dependent on global rules.
How?
Add a
box-sizing: border-boxrule to the block variation transforms component.Testing Instructions
This is a little artificial, but open up the post editor, add a Group block, and inspect element on the switcher in the sidebar where you switch to Row, Stack, Grid, etc.
Toggle the box-sizing rule for the post editor off, and on
trunkyou'll end up with a horizontal scrollbar.With this PR applied, no scrollbar should be present.
Screenshots or screencast
Before
After