Block Editor Components: Add missing style resets for fieldset elements #70685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
requested review from
getdave,
talldan and
tellthemachines
as code owners
andrewserong
added
the
[Type] Bug
andrewserong
added
[Feature] UI Components
Contributor
Does |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
It sure does! I'm slightly ashamed to admit I didn't even think to try it in JS, I was too focused thinking about how CSS is enqueued 😄 I'll update the testing instructions 👍 |
|
Size Change: +190 B (+0.01%) Total Size: 1.89 MB
ℹ️ View Unchanged
|
talldan
reviewed
Jul 11, 2025
| @@ -1,3 +1,10 @@ | |||
| fieldset.block-editor-block-variation-transforms { | |||
Contributor
There was a problem hiding this comment.
Is there a reason this one needs to be prefixed with fieldset? I'm guessing the classname is applied to non-fieldset elements too?
Just wondering if we want to be careful to keep the specificity low on these resets.
Contributor
Author
There was a problem hiding this comment.
Oh, good question! Due to how the block-editor-block-variation-transforms classname is applied, it can be used in two different states for variation transforms, and we only want the fieldset state. I can give it a :where() to reduce the specificity back down.
Contributor
Author
There was a problem hiding this comment.
Good catch. I just manually tested it by forcing the buttons to display, and with a :where() thrown in, it doesn't override the other padding rule below:
talldan
approved these changes
Jul 11, 2025
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
It tests well for me. The block lock modal looks a bit unusual without the common-css file. I wonder if there might need to be resets in place for list styles too:
I left one question, but it's a pretty minor thing that I'll let you address however you want.
Contributor
Author
|
Thanks for the quick review! I'm nearly at the end of my week, so I'll finish off on Monday.
Yes, we'll probably want to do a separate pass on |
youknowriad
approved these changes
Jul 11, 2025
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Thanks for fixing that.
Contributor
Author
I just reviewed the instances of |
cbravobernal
pushed a commit
that referenced
this pull request
Jul 15, 2025
…ts (#70685) * Block Editor Components: Add missing style resets for fieldset elements * Ensure specificity isn't too high Co-authored-by: andrewserong <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: youknowriad <[email protected]>
t-hamano
added
[Package] Block editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #70684
Add
fieldsetresets for a number of the block-editor components (those listed in #70684) that didn't already have them.Why?
Components in the components library appear to already be doing this, but a number in
block-editorweren't. Currently, the block editor components expect to be displayed within an admin context that includes CSS resets for thefieldsetelement. However, these components should be responsible for their own resets, similar to the components library.How?
I reviewed components in the
block-editorpackage to findfieldsetelements that didn't have resets, and then added them in. I think I've covered all the fieldsets with current usage in the block editor.Testing Instructions
Smoke test the following areas in the editor UI to make sure this doesn't break anything:
In normal usage, this PR should be identical to trunk. However if you want to test that these rules work, you can run the following in the browser console to remove
common.css:document.querySelector( 'link#common-css' ).remove().Screenshots or screencast
This is a pretty contrived before/after: