Editor post featured image: Ensure hidden text is hidden when common CSS is not loaded #72149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…css is not loaded
andrewserong
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +19 B (0%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Thanks for the review! 🙇 |
andrewserong
deleted the
fix/post-featured-image-describedby-when-common-css-is-not-available
branch
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 10, 2025
…css is not loaded (WordPress#72149) Co-authored-by: andrewserong <[email protected]> Co-authored-by: ramonjd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the editor post featured image component to ensure hidden text is hidden when common CSS is not loaded.
This is a similar kind of PR to some of my earlier ones that have been looking into removing our overall dependency on
common.cssresets (see: #71217 and #70685 for examples)Why?
Currently the post and site editors expect common.css to be loaded, however the editor can be used outside of a Gutenberg context where common.css might not be loaded (i.e. for plugins and custom editors). This PR ensures that the featured image doesn't accidentally display the describedby text in such a case, by ensuring that the component is responsible for its own
hiddenbehaviour.How?
display: nonerule to thehiddenclass for this component. This follows the same rule used incommon.cssTesting Instructions
Note: in normal usage this PR will appear to make no change vs trunk, so you'll need to follow the below instructions to see any difference
To replicate an environment that does not use common.css, load up the post editor and run the following from the console:
Then, add a featured image. With this PR applied, the describedby text should not display visually.
Testing Instructions for Keyboard
Screenshots or screencast