Template activation: adjust saveEntityRecord compat #72170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Oct 8, 2025
packages/core-data/src/actions.js
Outdated
| for ( const [ key, value ] of Object.entries( record ) ) { | ||
| if ( typeof value === 'function' ) { | ||
| const evaluatedValue = value( | ||
| select.getEditedEntityRecord( kind, name, recordId ) |
Member
Author
There was a problem hiding this comment.
Honestly not sure why this works because this is basically:
wp.data.select('core').getEditedEntityRecord('postType','wp_template','twentytwentyfour//home');
And there should be no edited entities with those IDs 🤔
Member
There was a problem hiding this comment.
Haven't checked, but it might be resolver forwarding. It looks like getEntityRecord is backward compatible.
gutenberg/packages/core-data/src/resolvers.js
Lines 230 to 233 in 7fdd9d2
Member
There was a problem hiding this comment.
Discovered a related (forwarded resolver) but different issue with this action recently as well 😅
|
Size Change: +1 B (0%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 676b389. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18348284693
|
Member
Author
|
No longer needed after #72223. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes
saveEntityRecord might be called with content properties that have a function. In that case, we need to fetch the current edited entity and call the function with the edited entity as an argument.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast