Skip to content

Template activation: adjust saveEntityRecord compat #72170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ellatrix wants to merge 2 commits into from
Closed

Template activation: adjust saveEntityRecord compat #72170

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4e3107
Template activation: adjust saveEntityRecord compat
ellatrix Oct 8, 2025
676b389
Merge logic
ellatrix Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/core-data/src/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,25 @@ export const saveEntityRecord =
'wp_registered_template',
recordId
);
// Evaluate optimized edits.
// (Function edits that should be evaluated on save to avoid expensive computations on every edit.)
for ( const [ key, value ] of Object.entries( record ) ) {
if ( typeof value === 'function' ) {
const evaluatedValue = value(
select.getEditedEntityRecord( kind, name, recordId )
Copy link
Member Author

@ellatrix ellatrix Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly not sure why this works because this is basically:

wp.data.select('core').getEditedEntityRecord('postType','wp_template','twentytwentyfour//home');

And there should be no edited entities with those IDs 🤔

Copy link
Member

@Mamaduka Mamaduka Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked, but it might be resolver forwarding. It looks like getEntityRecord is backward compatible.

gutenberg/packages/core-data/src/resolvers.js

Lines 230 to 233 in 7fdd9d2

/**
* Requests an entity's record from the REST API.
*/
export const getEditedEntityRecord = forwardResolver( 'getEntityRecord' );

Copy link
Member Author

@ellatrix ellatrix Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg, you're right!

Copy link
Member

@Mamaduka Mamaduka Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discovered a related (forwarded resolver) but different issue with this action recently as well 😅

#71927 (comment)

);
dispatch.editEntityRecord(
kind,
name,
recordId,
{
[ key ]: evaluatedValue,
},
{ undoIgnore: true }
);
record[ key ] = evaluatedValue;
}
}
// Duplicate the theme template and make the edit.
const newTemplate = await dispatch.saveEntityRecord(
'postType',
Expand Down
Loading