-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Theme: optimize seed adjustment #73004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0eb4d82
Theme: introduce a full suite of buildRamps tests
jsnajdr 6bcda18
Theme: use unadjusted seedL for bisection
jsnajdr 70dbc8e
Move deficit calculation to findColorMeetingRequirements
jsnajdr 81af116
Theme: interpolate seed colors for faster iteration
jsnajdr 8986d90
Set all contrast diff relative to seed
jsnajdr 283969f
Use Illinois bisection
jsnajdr 1760f6f
Better name for the epsilon constant
jsnajdr 044f654
Remove strict param, rename variables, use epsilons
jsnajdr 609a523
Increase background ramp test timeout to 10s
jsnajdr b0af9c7
Update test snapshots
jsnajdr 7f02df8
Measure deficit on same scale as contrast
jsnajdr a20492b
Recalculate only non-matching colors when adjusting seed
jsnajdr 5bed724
Document the stepsForStep function
jsnajdr 912f7cd
Use the RampConfig type
jsnajdr 8a4c2c7
Use lowercase names for variables
jsnajdr 3474192
Merge conditions
jsnajdr 9e5cf9a
stepsForStep: optimize a bit, move to utils
jsnajdr e017de1
Extracted common solveWithBisect helper
jsnajdr 1559ddc
Update test snapshots
jsnajdr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Theme: use unadjusted seedL for bisection
- Loading branch information
commit 6bcda187552787fa4adaeaade81ff821057bb91e
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mreishus recently pointed out that this comparison might be wrong. It's true, we want to compare:
The
MAX_DEFICIT_DIRECTION(formerlyUNSATISFIED_DIRECTION) value specifies in which direction did the first iteration fail to satisfy contrast constraint. And we want to lighten/darken the seed a little bit. But when doing the bisection, it can happen that whe move the seed too much in the opposite direction, and now it can't find contrastful colors in the opposite direction.In that case, we want to ignore the deficit value because it's not related to our calculation. It's better hardcoded to
-MAX_DEFICIT.