Skip to content

Theme: optimize seed adjustment #73004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsnajdr merged 19 commits into from
Nov 7, 2025
Merged

Theme: optimize seed adjustment #73004

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0eb4d82
Theme: introduce a full suite of buildRamps tests
jsnajdr Nov 3, 2025
6bcda18
Theme: use unadjusted seedL for bisection
jsnajdr Nov 3, 2025
70dbc8e
Move deficit calculation to findColorMeetingRequirements
jsnajdr Nov 3, 2025
81af116
Theme: interpolate seed colors for faster iteration
jsnajdr Nov 3, 2025
8986d90
Set all contrast diff relative to seed
jsnajdr Nov 4, 2025
283969f
Use Illinois bisection
jsnajdr Nov 4, 2025
1760f6f
Better name for the epsilon constant
jsnajdr Nov 4, 2025
044f654
Remove strict param, rename variables, use epsilons
jsnajdr Nov 5, 2025
609a523
Increase background ramp test timeout to 10s
jsnajdr Nov 5, 2025
b0af9c7
Update test snapshots
jsnajdr Nov 5, 2025
7f02df8
Measure deficit on same scale as contrast
jsnajdr Nov 6, 2025
a20492b
Recalculate only non-matching colors when adjusting seed
jsnajdr Nov 6, 2025
5bed724
Document the stepsForStep function
jsnajdr Nov 7, 2025
912f7cd
Use the RampConfig type
jsnajdr Nov 7, 2025
8a4c2c7
Use lowercase names for variables
jsnajdr Nov 7, 2025
3474192
Merge conditions
jsnajdr Nov 7, 2025
9e5cf9a
stepsForStep: optimize a bit, move to utils
jsnajdr Nov 7, 2025
e017de1
Extracted common solveWithBisect helper
jsnajdr Nov 7, 2025
1559ddc
Update test snapshots
jsnajdr Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test snapshots
  • Loading branch information
@jsnajdr
jsnajdr committed Nov 7, 2025
commit b0af9c702827ffecc38430aa1515311e4b4c5726
Loading