Skip to content

Notes: Improve delete confirm message for replies #73173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 5 commits into from
Nov 14, 2025
Merged

Notes: Improve delete confirm message for replies #73173

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7f478c
adjust delete confirm message for replies
adamsilverstein Nov 11, 2025
68eb07b
rework logic
adamsilverstein Nov 11, 2025
1a6d702
Update comments.js
adamsilverstein Nov 11, 2025
a383388
Update packages/editor/src/components/collab-sidebar/comments.js
t-hamano Nov 14, 2025
b7bc1c5
Fix invalid code
t-hamano Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/editor/src/components/collab-sidebar/comments.js
  • Loading branch information
@t-hamano
t-hamano committed Nov 14, 2025
commit a38338839d3c8b1b03b9ad98fdce61fae4214243
15 changes: 7 additions & 8 deletions packages/editor/src/components/collab-sidebar/comments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,14 +775,13 @@ const CommentBoard = ( {
: [];

let deleteConfirmMessage = __(
'Are you sure you want to delete this note?'
);

// When deleting a top level note, descendants will also be deleted.
if ( thread.parent === 0 ) {
deleteConfirmMessage +=
' ' + __( "This will also delete all of this note's replies." );
}
const deleteConfirmMessage =
// When deleting a top level note, descendants will also be deleted.
thread.parent === 0
? __(
"Are you sure you want to delete this note? This will also delete all of this note's replies."
)
: __( 'Are you sure you want to delete this reply?' );

return (
<VStack
Expand Down