Skip to content

Conversation

@karthick-murugan
Copy link
Contributor

@karthick-murugan karthick-murugan commented Nov 12, 2025

What?

Closes #73187

This PR updates the text label of the "Add new note" button to "Add new reply" for improved clarity and accessibility.

Why?

Previously, the label “Add new note” could be misinterpreted as an action to create a new note on a different block, rather than replying to the existing note thread.

How?

Testing Instructions

  1. Insert a block and add a note to it.
  2. Focus on the note using the Tab key.
  3. Press Tab again to focus the button.
  4. Confirm that the button now reads “Add new reply” instead of “Add new note.”
  5. Add a reply and ensure the behavior remains unchanged.
  6. Run E2E tests to confirm all related tests pass successfully.

Video

REC-20251112142209.mp4

@karthick-murugan karthick-murugan changed the title Update note copy to reply Update button label from "Add new note" to "Add new reply" Nov 12, 2025
@karthick-murugan karthick-murugan marked this pull request as ready for review November 12, 2025 09:55
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: Dhruval-678 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: jeffpaul <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Dhruval-678
Copy link

== Test Report
=== Description
This report validates whether the indicated patch works as expected IN PLAYGROUND

Patch tested: #73189

=== Environment

  • WordPress: 6.8.3
  • PHP: 8.3.27-dev
  • Server: PHP.wasm
  • Database: WP_SQLite_Driver (Server: 8.0.38 / Client: 3.40.1)
  • Browser: Chrome 142.0.0.0
  • OS: Linux
  • Theme: Twenty Twenty-Five 1.3
  • MU Plugins: None activated
  • Plugins:
    • Gutenberg 22.0.0
    • Test Reports 1.2.1

=== Actual Results

  1. ✅ Issue resolved with patch.

@Dhruval-678
Copy link

Notes.button.Text.mp4

@Mamaduka Mamaduka added [Type] Copy Issues or PRs that need copy editing assistance [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting labels Nov 12, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @karthick-murugan!

@adamsilverstein, @t-hamano, if we get a green light for #73173, the we can also backport this change.

@t-hamano
Copy link
Contributor

@Mamaduka, I am concerned about whether the strings can be changed after the RC1 release. See also: #73173 (review)

@Mamaduka
Copy link
Member

@t-hamano, usually they can't be changed in RCs, at least that's my understanding. But I've seens some exception, not sure if this qualifies, though.

@t-hamano
Copy link
Contributor

@Mamaduka, since the Notes is a new feature, the rules might be relaxed a bit. Do we check with tech leads or the Polyglot team?

@Mamaduka
Copy link
Member

@t-hamano, sounds good. Let's check with the leads; the release channel should be a good place for it.

@jeffpaul
Copy link
Member

FYI looks like some approval to proceed with this string change: https://wordpress.slack.com/archives/C08MVR1MU2K/p1762953559123909

@Mamaduka Mamaduka added the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 12, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.9 Editor Tasks Nov 12, 2025
@Mamaduka Mamaduka merged commit aa4c302 into WordPress:trunk Nov 12, 2025
44 of 45 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.9 Editor Tasks Nov 12, 2025
@github-actions github-actions bot added this to the Gutenberg 22.2 milestone Nov 12, 2025
@github-actions github-actions bot removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 12, 2025
gutenbergplugin pushed a commit that referenced this pull request Nov 12, 2025
Co-authored-by: karthick-murugan <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: Dhruval-678 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: jeffpaul <[email protected]>
@github-actions github-actions bot added the Backported to WP Core Pull request that has been successfully merged into WP Core label Nov 12, 2025
@github-actions
Copy link

I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 10a5e6d

@karthick-murugan karthick-murugan deleted the note-reply-copy branch November 13, 2025 04:13
@priethor
Copy link
Contributor

Thanks for double-checking the string change post RC!

markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Nov 18, 2025
Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/.

- [Block Bindings: Add unit test coverage for `core/post-data` source](WordPress/gutenberg#73055)
- [Block Bindings: Error handling for external sources.](WordPress/gutenberg#72585)
- [Notes: Collapse note on blur](WordPress/gutenberg#73158)
- [Border-radius values triggers unintended px conversion](WordPress/gutenberg#73324)
- [Fix navigation tag entity binding](WordPress/gutenberg#73255)
- [DataViews: ensure primary actions are not wrapped in the list layout](WordPress/gutenberg#73345)
- [Fix: Fit Text may overflow into the padding area.](WordPress/gutenberg#73327)
- [Merge "Icon Size" and "Icon size" translation strings](WordPress/gutenberg#73325)
- [Notes: Improve delete confirm message for replies](WordPress/gutenberg#73173)
- [Fix: Custom font size taking over fit text.](WordPress/gutenberg#73241)
- [Fix a11y of descriptions and alerts for "Invalid" Nav Items](WordPress/gutenberg#73177)
- [Stretchy text: Hide variations in Block Inspector (hack)](WordPress/gutenberg#73238)
- [Update button label from "Add new note" to "Add new reply"](WordPress/gutenberg#73189)
- [Notes: Fix first note creation with pinned sidebar](WordPress/gutenberg#73164)

Developed in WordPress/wordpress-develop#10528.
See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches.

Fixes #64267.
Props priethor.
Built from https://develop.svn.wordpress.org/trunk@61262


git-svn-id: http://core.svn.wordpress.org/trunk@60574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Nov 18, 2025
Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/.

- [Block Bindings: Add unit test coverage for `core/post-data` source](WordPress/gutenberg#73055)
- [Block Bindings: Error handling for external sources.](WordPress/gutenberg#72585)
- [Notes: Collapse note on blur](WordPress/gutenberg#73158)
- [Border-radius values triggers unintended px conversion](WordPress/gutenberg#73324)
- [Fix navigation tag entity binding](WordPress/gutenberg#73255)
- [DataViews: ensure primary actions are not wrapped in the list layout](WordPress/gutenberg#73345)
- [Fix: Fit Text may overflow into the padding area.](WordPress/gutenberg#73327)
- [Merge "Icon Size" and "Icon size" translation strings](WordPress/gutenberg#73325)
- [Notes: Improve delete confirm message for replies](WordPress/gutenberg#73173)
- [Fix: Custom font size taking over fit text.](WordPress/gutenberg#73241)
- [Fix a11y of descriptions and alerts for "Invalid" Nav Items](WordPress/gutenberg#73177)
- [Stretchy text: Hide variations in Block Inspector (hack)](WordPress/gutenberg#73238)
- [Update button label from "Add new note" to "Add new reply"](WordPress/gutenberg#73189)
- [Notes: Fix first note creation with pinned sidebar](WordPress/gutenberg#73164)

Developed in WordPress/wordpress-develop#10528.
See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches.

Fixes #64267.
Props priethor.
Built from https://develop.svn.wordpress.org/trunk@61262


git-svn-id: https://core.svn.wordpress.org/trunk@60574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
hubot pushed a commit to nacin/wp-develop that referenced this pull request Nov 18, 2025
Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/.

- [Block Bindings: Add unit test coverage for `core/post-data` source](WordPress/gutenberg#73055)
- [Block Bindings: Error handling for external sources.](WordPress/gutenberg#72585)
- [Notes: Collapse note on blur](WordPress/gutenberg#73158)
- [Border-radius values triggers unintended px conversion](WordPress/gutenberg#73324)
- [Fix navigation tag entity binding](WordPress/gutenberg#73255)
- [DataViews: ensure primary actions are not wrapped in the list layout](WordPress/gutenberg#73345)
- [Fix: Fit Text may overflow into the padding area.](WordPress/gutenberg#73327)
- [Merge "Icon Size" and "Icon size" translation strings](WordPress/gutenberg#73325)
- [Notes: Improve delete confirm message for replies](WordPress/gutenberg#73173)
- [Fix: Custom font size taking over fit text.](WordPress/gutenberg#73241)
- [Fix a11y of descriptions and alerts for "Invalid" Nav Items](WordPress/gutenberg#73177)
- [Stretchy text: Hide variations in Block Inspector (hack)](WordPress/gutenberg#73238)
- [Update button label from "Add new note" to "Add new reply"](WordPress/gutenberg#73189)
- [Notes: Fix first note creation with pinned sidebar](WordPress/gutenberg#73164)

Developed in WordPress/wordpress-develop#10528.
See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches.

Fixes #64267.
Props priethor.

git-svn-id: https://develop.svn.wordpress.org/trunk@61262 602fd350-edb4-49c9-b593-d223f7449a82
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Nov 18, 2025
Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/.

[Block Bindings: Add unit test coverage for core/post-data source](WordPress/gutenberg#73055)
[Block Bindings: Error handling for external sources.](WordPress/gutenberg#72585)
[Notes: Collapse note on blur](WordPress/gutenberg#73158)
[Border-radius values triggers unintended px conversion](WordPress/gutenberg#73324)
[Fix navigation tag entity binding](WordPress/gutenberg#73255)
[DataViews: ensure primary actions are not wrapped in the list layout](WordPress/gutenberg#73345)
[Fix: Fit Text may overflow into the padding area.](WordPress/gutenberg#73327)
[Merge "Icon Size" and "Icon size" translation strings](WordPress/gutenberg#73325)
[Notes: Improve delete confirm message for replies](WordPress/gutenberg#73173)
[Fix: Custom font size taking over fit text.](WordPress/gutenberg#73241)
[Fix a11y of descriptions and alerts for "Invalid" Nav Items](WordPress/gutenberg#73177)
[Stretchy text: Hide variations in Block Inspector (hack)](WordPress/gutenberg#73238)
[Update button label from "Add new note" to "Add new reply"](WordPress/gutenberg#73189)
[Notes: Fix first note creation with pinned sidebar](WordPress/gutenberg#73164)
Developed in #10528.
See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches.

Reviewed by davidbaumwald.
Merges [61262] to the 6.9 branch.

Props priethor, ellatrix.
See #64267.

git-svn-id: https://develop.svn.wordpress.org/branches/6.9@61263 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Nov 18, 2025
Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/.

[Block Bindings: Add unit test coverage for core/post-data source](WordPress/gutenberg#73055)
[Block Bindings: Error handling for external sources.](WordPress/gutenberg#72585)
[Notes: Collapse note on blur](WordPress/gutenberg#73158)
[Border-radius values triggers unintended px conversion](WordPress/gutenberg#73324)
[Fix navigation tag entity binding](WordPress/gutenberg#73255)
[DataViews: ensure primary actions are not wrapped in the list layout](WordPress/gutenberg#73345)
[Fix: Fit Text may overflow into the padding area.](WordPress/gutenberg#73327)
[Merge "Icon Size" and "Icon size" translation strings](WordPress/gutenberg#73325)
[Notes: Improve delete confirm message for replies](WordPress/gutenberg#73173)
[Fix: Custom font size taking over fit text.](WordPress/gutenberg#73241)
[Fix a11y of descriptions and alerts for "Invalid" Nav Items](WordPress/gutenberg#73177)
[Stretchy text: Hide variations in Block Inspector (hack)](WordPress/gutenberg#73238)
[Update button label from "Add new note" to "Add new reply"](WordPress/gutenberg#73189)
[Notes: Fix first note creation with pinned sidebar](WordPress/gutenberg#73164)
Developed in WordPress/wordpress-develop#10528.
See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches.

Reviewed by davidbaumwald.
Merges [61262] to the 6.9 branch.

Props priethor, ellatrix.
See #64267.
Built from https://develop.svn.wordpress.org/branches/6.9@61263


git-svn-id: http://core.svn.wordpress.org/branches/6.9@60575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting [Type] Copy Issues or PRs that need copy editing assistance

Projects

Development

Successfully merging this pull request may close these issues.

Notes: The text of the "Add new note" button should be "Add new reply".

6 participants