Skip to content

ContentOnlyControls: Refactor to use DataForm #73374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 12 commits into from
Nov 20, 2025
Merged

ContentOnlyControls: Refactor to use DataForm #73374

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
90fd2a2
ContentOnlyControls: Switch to using DataForm
andrewserong Nov 18, 2025
e8c1ca4
Fix media with Cover, Media and Text, and Image blocks
andrewserong Nov 18, 2025
c13fd67
Toggle off featured image when doing other things
andrewserong Nov 18, 2025
db2641a
Fix linting issue... hopefully
andrewserong Nov 19, 2025
1d591a1
Fix the mapping
andrewserong Nov 19, 2025
e32127c
Update dropdown label
andrewserong Nov 19, 2025
a14a4aa
Try making things a tiny bit more consistent
andrewserong Nov 19, 2025
61164f9
Revert tiny clientId change
andrewserong Nov 19, 2025
468eadc
Tidy up properties
andrewserong Nov 20, 2025
0ee4dd4
Try to make normalize a little more consistent with the denormalize f…
andrewserong Nov 20, 2025
2a822b2
Ensure there's padding for the bottom field
andrewserong Nov 20, 2025
7924282
Update popover positioning for the dropdown menus
andrewserong Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update popover positioning for the dropdown menus
  • Loading branch information
@andrewserong
andrewserong committed Nov 20, 2025
commit 79242824dba8d1ab6a0e196e146c5376fae86620
9 changes: 8 additions & 1 deletion packages/block-editor/src/components/content-only-controls/fields-dropdown-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,18 @@ import { DropdownMenu, MenuGroup, MenuItem } from '@wordpress/components';
import { moreVertical, check } from '@wordpress/icons';
import { __ } from '@wordpress/i18n';

/**
* Internal dependencies
*/
import { useInspectorPopoverPlacement } from './use-inspector-popover-placement';

export default function FieldsDropdownMenu( {
fields,
visibleFields,
onToggleField,
} ) {
const { popoverProps } = useInspectorPopoverPlacement();

if ( ! fields || fields.length === 0 ) {
return null;
}
Expand All @@ -18,7 +25,7 @@ export default function FieldsDropdownMenu( {
<DropdownMenu
icon={ moreVertical }
label={ __( 'Options' ) }
popoverProps={ { placement: 'bottom-end' } }
popoverProps={ popoverProps }
>
{ ( { onClose } ) => (
<MenuGroup label={ __( 'Show / Hide' ) }>
Expand Down
Loading