-
Notifications
You must be signed in to change notification settings - Fork 4.7k
ContentOnlyControls: Refactor to use DataForm #73374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andrewserong
merged 12 commits into
trunk
from
try/switch-content-only-controls-to-dataform
Nov 20, 2025
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
90fd2a2
ContentOnlyControls: Switch to using DataForm
andrewserong e8c1ca4
Fix media with Cover, Media and Text, and Image blocks
andrewserong c13fd67
Toggle off featured image when doing other things
andrewserong db2641a
Fix linting issue... hopefully
andrewserong 1d591a1
Fix the mapping
andrewserong e32127c
Update dropdown label
andrewserong a14a4aa
Try making things a tiny bit more consistent
andrewserong 61164f9
Revert tiny clientId change
andrewserong 468eadc
Tidy up properties
andrewserong 0ee4dd4
Try to make normalize a little more consistent with the denormalize f…
andrewserong 2a822b2
Ensure there's padding for the bottom field
andrewserong 7924282
Update popover positioning for the dropdown menus
andrewserong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Toggle off featured image when doing other things
- Loading branch information
commit c13fd67c660d2fb19242e3094df42be6db1f5412
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the plan be to make these use
field.setValuein the future?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! While troubleshooting, I found it easier for this PR to just pop
updateAttributesin here for now, but I'd like to refactor this in a follow-up, too