Skip to content

BlockBreadcrumb: Show custom block name #73690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t-hamano wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

BlockBreadcrumb: Show custom block name #73690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a88f153
BlockBreadcrumb: Show custom block name
t-hamano Dec 2, 2025
7772d3d
Clarify fallback logic in navigation-submenu block
t-hamano Dec 3, 2025
0d4d164
Navigation Submenu: simpliy logic
t-hamano Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/block-editor/src/components/block-breadcrumb/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ function BlockBreadcrumb( { rootLabelText } ) {
<BlockTitle
clientId={ parentClientId }
maximumLength={ 35 }
context="breadcrumb"
/>
</Button>
<Icon
Expand All @@ -114,7 +115,11 @@ function BlockBreadcrumb( { rootLabelText } ) {
className="block-editor-block-breadcrumb__current"
aria-current="true"
>
<BlockTitle clientId={ clientId } maximumLength={ 35 } />
<BlockTitle
clientId={ clientId }
maximumLength={ 35 }
context="breadcrumb"
/>
</li>
) }
</ul>
Expand Down
7 changes: 5 additions & 2 deletions packages/block-editor/src/hooks/block-renaming.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,11 @@ export function addLabelCallback( settings ) {
settings.__experimentalLabel = ( attributes, { context } ) => {
const { metadata } = attributes;

// In the list view, use the block's name attribute as the label.
if ( context === 'list-view' && metadata?.name ) {
// In the list view and breadcrumb, use the block's name attribute as the label.
if (
( context === 'list-view' || context === 'breadcrumb' ) &&
metadata?.name
) {
return metadata.name;
}
};
Expand Down
4 changes: 4 additions & 0 deletions packages/block-library/src/details/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ export const settings = {
return customName || summary;
}

if ( context === 'breadcrumb' && customName ) {
return customName;
}

if ( context === 'accessibility' ) {
return ! hasSummary
? __( 'Details. Empty.' )
Expand Down
4 changes: 4 additions & 0 deletions packages/block-library/src/heading/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ export const settings = {
return customName || content;
}

if ( context === 'breadcrumb' && customName ) {
return customName;
}

if ( context === 'accessibility' ) {
return ! hasContent
? sprintf(
Expand Down
5 changes: 4 additions & 1 deletion packages/block-library/src/image/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ export const settings = {
__experimentalLabel( attributes, { context } ) {
const customName = attributes?.metadata?.name;

if ( context === 'list-view' && customName ) {
if (
( context === 'list-view' || context === 'breadcrumb' ) &&
customName
) {
return customName;
}

Expand Down
5 changes: 4 additions & 1 deletion packages/block-library/src/more/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ export const settings = {
__experimentalLabel( attributes, { context } ) {
const customName = attributes?.metadata?.name;

if ( context === 'list-view' && customName ) {
if (
( context === 'list-view' || context === 'breadcrumb' ) &&
customName
) {
return customName;
}

Expand Down
9 changes: 6 additions & 3 deletions packages/block-library/src/navigation-submenu/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,13 @@ export const settings = {

const customName = attributes?.metadata?.name;

// In the list view, use the block's menu label as the label.
// In the list view and breadcrumb, use the block's menu label as the label.
// If the menu label is empty, fall back to the default label.
if ( context === 'list-view' && ( customName || label ) ) {
return attributes?.metadata?.name || label;
if (
( context === 'list-view' || context === 'breadcrumb' ) &&
customName
) {
return customName;
}

return label;
Expand Down
5 changes: 4 additions & 1 deletion packages/block-library/src/paragraph/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ export const settings = {
__experimentalLabel( attributes, { context } ) {
const customName = attributes?.metadata?.name;

if ( context === 'list-view' && customName ) {
if (
( context === 'list-view' || context === 'breadcrumb' ) &&
customName
) {
return customName;
}

Expand Down
Loading