BlockBreadcrumb: Show custom block name #73690
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
force-pushed
the
block-breadcrumb-custom-name
branch
from
4a93f96 to
ba93fa3
Compare
t-hamano
force-pushed
the
block-breadcrumb-custom-name
branch
from
ba93fa3 to
a88f153
Compare
t-hamano
added
[Type] Enhancement
t-hamano
requested review from
ajitbohra,
ellatrix,
fabiankaegy and
tellthemachines
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @landwire. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +60 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
Contributor
|
This resonates insofar as the breadcrumbs have a direct relationship with the list view, and should be the same. Good PR. The one concern is that the crumb can be long if you insert patterns with long titles, such as "Two overlapping pictures and heading", but there should be room. |
Mamaduka
reviewed
Dec 2, 2025
Member
The title is truncated at 35 chars - https://github.com/WordPress/gutenberg/pull/73690/files#diff-0b9cce589213e49c27e3109f5f5c4ae4347c239ef1ee833960a6f25b34735d45R118-R122. IMO, the same problem would apply to blocks with long titles. |
Contributor
Author
Yes, longer text is truncated nicely. We can truncate more characters if we want: 
|
|
Flaky tests detected in 7772d3d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19889800150
|
Mamaduka
approved these changes
Dec 3, 2025
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Looks good to me code-wise; I'll defer to the design team for final approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56523 (I think)
See: #56523 (comment)
What? Why?
I think breadcrumbs should display custom block names just like the List View.
How?
For breadcrumbs, I add a dedicated
breadcrumbcontext. Thebreadcrumbcontext respects custom name, just like thelist-viewcontext, but with a few differences in some blocks:list-view: Custom name or summary contentbreadcrumb: Custom namelist-view: Custom name or contentbreadcrumb: Custom nameBreadcrumbs don't have block icons, so I avoided using content for breadcrumbs because it's hard to tell what a block is just from its content.
Testing Instructions
Use the following markup to confirm various blocks with custom names and contents.
Screenshots or screencast
Before
After