ToolsPanel: Remove line-height workaround

[mirka]

What?

Closes #42788

Removes the workaround for unifying control label line-heights in ToolsPanel.

Why?

I can no longer reproduce the original issue that motivated the workaround.

Testing Instructions

Go to a Typography tools panel in the editor, and show the Appearance and Letter Spacing controls next to each other.

You could also try rendering an InputControl-based component and a BaseControl-based component next to each other in Storybook.

Screenshots or screencast

No alignment issues even after removing the workaround. (Here's what the original misalignment looked like.)

Some components rendered next to each other in Storybook:

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <[email protected]>
Co-authored-by: aduth <[email protected]>
Co-authored-by: aaronrobertshaw <[email protected]>
Co-authored-by: youknowriad <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[aduth]

LGTM 👍

Wonder if #37844 was part of the fix here? Curious that it removed the other compatibility styles except the line-height.

[aaronrobertshaw]

LGTM also.

Thanks for cleaning this up @mirka 👍