Skip to content

ToolsPanel: Remove line-height workaround #73892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 2 commits into from
Dec 11, 2025
+1 −14
Merged

ToolsPanel: Remove line-height workaround #73892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c2ec42
ToolsPanel: Remove line-height workaround
mirka Dec 10, 2025
532e12e
Add changelog
mirka Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- `Menu` and othr menu items: change default size to be 32px tall rather than 40px to improve menu density. ([#73429](https://github.com/WordPress/gutenberg/pull/73429)).
- Unify padding using for DataViews, Modals and other container components. ([#73334](https://github.com/WordPress/gutenberg/pull/73334))
- `Snackbar`: Shorten timeout duration ([#73814](https://github.com/WordPress/gutenberg/pull/73814)).
- `ToolsPanel`: Remove line-height workaround for control labels ([#73892](https://github.com/WordPress/gutenberg/pull/73892)).

### Bug Fixes

Expand Down
14 changes: 0 additions & 14 deletions packages/components/src/tools-panel/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
StyledHelp as BaseControlHelp,
Wrapper as BaseControlWrapper,
} from '../base-control/styles/base-control-styles';
import { LabelWrapper } from '../input-control/styles/input-control-styles';
import { COLORS, CONFIG, rtl } from '../utils';
import { space } from '../utils/space';

Expand Down Expand Up @@ -124,19 +123,6 @@ export const ToolsPanelItem = css`
${ BaseControlHelp } {
margin-bottom: 0;
}

/**
* Standardize InputControl and BaseControl labels with other labels when
* inside ToolsPanel.
*
* This is a temporary fix until the different control components have their
* labels normalized.
*/
&& ${ LabelWrapper } {
label {
line-height: 1.4em;
}
}
`;

export const ToolsPanelItemPlaceholder = css`
Expand Down
Loading