Media fields: Add tests for fields with unique logic #74015

ramonjd · 2025-12-16T01:49:07Z

What?

Related to #72612 (comment) and partial follow up to #73071

Add unit tests for media fields: filename, filesize, media dimensions.

filename field (7 tests): Field configuration, filename extraction via getValue, and view component rendering (short/long filenames, edge cases)
filesize field (20 tests): Field configuration, byte formatting logic (B → KB → MB → GB → TB with proper decimal handling), and isVisible behavior
media_dimensions field (8 tests): Field configuration, dimension formatting (width × height), and isVisible behavior

I think the media thumbnail could an E2E test? Happy to try to mock that up too if required.

Testing Instructions

Tests should pass!

ramonjd · 2025-12-16T01:50:14Z

packages/media-fields/src/filesize/test/index.test.tsx

+		expect( filesizeField ).toMatchObject( {
+			id: 'filesize',
+			type: 'text',
+			label: 'File size',
+			enableSorting: false,
+			filterBy: false,
+			readOnly: true,
+		} );
+	} );


These kind of expectations might be an overkill?

Hrm... could be! If pressed, I'd say the has correct field configuration test does feel a bit overkill as it's unlikely to be a useful test for us. That said, it's very easy to change if it causes any trouble, so I don't mind either way.

github-actions · 2025-12-16T01:50:24Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @Copilot.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: Copilot.

Co-authored-by: ramonjd <[email protected]>
Co-authored-by: andrewserong <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copilot

Pull request overview

This PR adds comprehensive unit tests for media fields with unique logic, covering filename, filesize, and media_dimensions fields. The tests validate field configuration, data extraction/formatting logic, visibility conditions, and view component rendering behavior.

Key Changes:

Added 7 tests for filename field covering configuration, getValue extraction, and view rendering with various filename lengths
Added 20 tests for filesize field covering configuration, byte unit formatting (B through TB), and isVisible behavior
Added 8 tests for media_dimensions field covering configuration, dimension formatting, and isVisible behavior

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File	Description
packages/media-fields/src/media_dimensions/test/index.test.ts	Adds tests for media dimensions field configuration, getValue dimension formatting with × separator, and isVisible logic
packages/media-fields/src/filesize/test/index.test.tsx	Adds tests for filesize field configuration, byte formatting across multiple units with decimal handling, and isVisible behavior
packages/media-fields/src/filename/test/view.test.tsx	Adds tests for filename view component rendering with short/long filenames and edge cases
packages/media-fields/src/filename/test/index.test.ts	Adds tests for filename field configuration and getValue extraction from source_url

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/media-fields/src/filesize/test/index.test.tsx

packages/media-fields/src/media_dimensions/test/index.test.ts

packages/media-fields/src/filename/test/index.test.ts

Copilot · 2025-12-16T01:53:30Z

@ramonjd I've opened a new pull request, #74016, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-16T01:55:30Z

@ramonjd I've opened a new pull request, #74017, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-16T01:55:32Z

@ramonjd I've opened a new pull request, #74018, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-16T01:55:35Z

@ramonjd I've opened a new pull request, #74019, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-16T01:55:39Z

@ramonjd I've opened a new pull request, #74020, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-16T01:56:34Z

@ramonjd I've opened a new pull request, #74021, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-16T01:56:44Z

@ramonjd I've opened a new pull request, #74022, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-16T01:57:00Z

@ramonjd I've opened a new pull request, #74023, to work on those changes. Once the pull request is ready, I'll request review from you.

ramonjd · 2025-12-16T02:25:30Z

LOL, thanks for all the PRs copilot

github-actions · 2025-12-16T03:06:22Z

Flaky tests detected in 13ae070.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20254574974
📝 Reported issues:

[Flaky Test] should show the original content after revert and page reload #68604 in /test/e2e/specs/site-editor/template-revert.spec.js

andrewserong

Thanks for adding the tests! Hope you don't mind, but I've pushed a Claude-assisted change to consolidate some of the repetitive tests to use it.each() to group them together for readability. But feel free to keep moving things around if you preferred a different structure.

LGTM! 🚀

andrewserong · 2025-12-18T00:39:40Z

packages/media-fields/src/filesize/test/index.test.tsx

+		expect( filesizeField ).toMatchObject( {
+			id: 'filesize',
+			type: 'text',
+			label: 'File size',
+			enableSorting: false,
+			filterBy: false,
+			readOnly: true,
+		} );
+	} );


Hrm... could be! If pressed, I'd say the has correct field configuration test does feel a bit overkill as it's unlikely to be a useful test for us. That said, it's very easy to change if it causes any trouble, so I don't mind either way.

ramonjd · 2025-12-18T00:47:30Z

to group them together for readability. But feel free to keep moving things around if you preferred a different structure.

Thank you! All changes are welcome 🙇🏻

Co-authored-by: ramonjd <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]>

…74021) Co-authored-by: ramonjd <[email protected]>

…74022) Co-authored-by: ramonjd <[email protected]>

…74023) Co-authored-by: ramonjd <[email protected]>

…#74018) Co-authored-by: ramonjd <[email protected]>

Co-authored-by: ramonjd <[email protected]>

ramonjd · 2025-12-18T00:48:56Z

Just rebasing and kicking off tests again. Some funky e2e fails, not related I presume

andrewserong · 2025-12-18T00:50:16Z

Oh, I think I might have missed a TypeScript error, I'll take a quick look

andrewserong · 2025-12-18T01:24:56Z

Just kicked the e2es off again. Looks like the TS issue is fixed, so I'm pretty sure this one was just flaky. We'll see if the auto-merge winds up doing its thing!

ramonjd requested review from andrewserong and Copilot December 16, 2025 01:49

ramonjd self-assigned this Dec 16, 2025

ramonjd added [Feature] Media Anything that impacts the experience of managing media [Type] Code Quality Issues or PRs that relate to code quality labels Dec 16, 2025

Copilot started reviewing on behalf of ramonjd December 16, 2025 01:49 View session

ramonjd commented Dec 16, 2025

View reviewed changes

ramonjd mentioned this pull request Dec 16, 2025

Media Library: Add DataViews/Forms fields specific to media/attachments #72612

Closed

12 tasks

Copilot AI reviewed Dec 16, 2025

View reviewed changes

This was referenced Dec 16, 2025

Fix misleading test description for 0 bytes filesize handling #74016

Merged

Add edge case tests for filename field getValue #74017

Merged

This was referenced Dec 16, 2025

Add edge case tests for 0-valued dimensions in media_dimensions field #74018

Merged

Add edge case tests for zero-value dimensions in media fields #74019

Merged

Copilot AI mentioned this pull request Dec 16, 2025

Add missing test case for isVisible when media_details is undefined #74020

Closed

Copilot AI mentioned this pull request Dec 16, 2025

Add missing test case for isVisible when media_details is undefined #74021

Merged

This was referenced Dec 16, 2025

Add missing test case for isVisible when media_details is undefined #74022

Merged

Fix misleading test description for filesize field 0 bytes behavior #74023

Merged

andrewserong approved these changes Dec 18, 2025

View reviewed changes

ramonjd and others added 10 commits December 18, 2025 11:48

Add unit tests for media fields: filename, filesize, media dimensions

bb17526

Remove redundant unit tests for media dimensions formatting

5f65f36

Fix misleading test description for 0 bytes filesize handling (#74016)

359cdf5

Co-authored-by: ramonjd <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]>

Add missing test case for isVisible when media_details is undefined (#…

620d1c9

…74021) Co-authored-by: ramonjd <[email protected]>

Add missing test case for isVisible when media_details is undefined (#…

7d362e9

…74022) Co-authored-by: ramonjd <[email protected]>

Fix misleading test description for filesize field 0 bytes behavior (#…

641d430

…74023) Co-authored-by: ramonjd <[email protected]>

Add edge case tests for 0-valued dimensions in media_dimensions field (…

eb8e336

…#74018) Co-authored-by: ramonjd <[email protected]>

Add edge case tests for zero-value dimensions in media fields (#74019)

6a1d5d7

Co-authored-by: ramonjd <[email protected]>

Add edge case tests for filename field getValue (#74017)

531a500

Co-authored-by: ramonjd <[email protected]>

Consolidate some of the tests via it.each()

5175d8d

ramonjd force-pushed the add/media-fields-tests branch from 2ab6faf to 5175d8d Compare December 18, 2025 00:48

ramonjd enabled auto-merge (squash) December 18, 2025 00:49

Attempt to fix TS issues

f57291c

ramonjd merged commit e51d410 into trunk Dec 18, 2025
41 of 45 checks passed

ramonjd deleted the add/media-fields-tests branch December 18, 2025 01:47

github-actions bot added this to the Gutenberg 22.4 milestone Dec 18, 2025

Media fields: Add tests for fields with unique logic #74015

Media fields: Add tests for fields with unique logic #74015

Uh oh!

Conversation

ramonjd commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Testing Instructions

Uh oh!

ramonjd Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

andrewserong Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unlinked Accounts

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Dec 16, 2025

Uh oh!

Copilot AI commented Dec 16, 2025

Uh oh!

Copilot AI commented Dec 16, 2025

Uh oh!

Copilot AI commented Dec 16, 2025

Uh oh!

Copilot AI commented Dec 16, 2025

Uh oh!

Copilot AI commented Dec 16, 2025

Uh oh!

Copilot AI commented Dec 16, 2025

Uh oh!

Copilot AI commented Dec 16, 2025

Uh oh!

ramonjd commented Dec 16, 2025

Uh oh!

github-actions bot commented Dec 16, 2025

Uh oh!

andrewserong left a comment

Choose a reason for hiding this comment

Uh oh!

andrewserong Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

ramonjd commented Dec 18, 2025

Uh oh!

ramonjd commented Dec 18, 2025

Uh oh!

andrewserong commented Dec 18, 2025

Uh oh!

andrewserong commented Dec 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ramonjd commented Dec 16, 2025 •

edited

Loading

github-actions bot commented Dec 16, 2025 •

edited

Loading