Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 16, 2025

The test for getValue() returning an empty string when filesize is 0 incorrectly attributed this behavior to isVisible hiding the value. The actual cause is the truthy check in getValue() itself.

Root cause

The getValue implementation uses a truthy check:

getValue: ( { item }: { item: MediaItem } ) =>
    item?.media_details?.filesize
        ? formatFileSize( item?.media_details?.filesize )
        : '',

When filesize is 0, the truthy check treats it as falsy and returns an empty string before formatFileSize() is ever called. The formatFileSize() function itself would return "0 B" if it received 0.

Changes

  • Updated test description from "handled by isVisible" to "due to truthy check"
  • Updated inline comment to accurately explain the truthy check behavior treating 0 as falsy

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor Author

Copilot AI commented Dec 16, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • translate.wordpress.org
    • Triggering command: /usr/local/bin/node node i18n-cache/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update tests for media fields based on review feedback Fix misleading test description for 0 bytes filesize handling Dec 16, 2025
Copilot AI requested a review from ramonjd December 16, 2025 01:57
@ramonjd ramonjd marked this pull request as ready for review December 16, 2025 02:26
@github-actions
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Required label: Any label starting with [Type].
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @Copilot.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: Copilot.

Co-authored-by: ramonjd <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ramonjd ramonjd merged commit 4b2f3e9 into add/media-fields-tests Dec 16, 2025
2 of 3 checks passed
@ramonjd ramonjd deleted the copilot/sub-pr-74015 branch December 16, 2025 02:27
ramonjd added a commit that referenced this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants