Skip to content

Conversation

@SirLouen
Copy link
Member

Adding some unit tests for #74163

For some reason they have not been merged in c1e52cd
But no problem, we can merge them now.

I have removed the undefined and null tests as Riad suggested.

cc @youknowriad

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SirLouen <[email protected]>
Co-authored-by: youknowriad <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the [Package] Block library /packages/block-library label Dec 23, 2025
@SirLouen SirLouen added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Block] Buttons Affects the Buttons Block labels Dec 23, 2025
@SirLouen
Copy link
Member Author

@youknowriad I've added the context and added an extra test with a different context.

@SirLouen SirLouen requested a review from youknowriad December 23, 2025 19:24
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool. Thanks

@youknowriad youknowriad enabled auto-merge (squash) December 23, 2025 19:37
@youknowriad youknowriad merged commit f398e78 into WordPress:trunk Dec 23, 2025
37 checks passed
@github-actions github-actions bot added this to the Gutenberg 22.4 milestone Dec 23, 2025
@SirLouen SirLouen deleted the tests/74163 branch December 27, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Buttons Affects the Buttons Block [Package] Block library /packages/block-library [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants