Button: Improve the label of the button block in list view #74163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
commented
Dec 22, 2025
| ...a, | ||
| text: ( a.text || '' ) + text, | ||
| } ), | ||
| __experimentalLabel( attributes ) { |
Contributor
Author
There was a problem hiding this comment.
It's probably time to make this stable.
Member
There was a problem hiding this comment.
Yeah, I think it's time. I think we even had an issue with it.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +70 B (0%) Total Size: 2.57 MB
ℹ️ View Unchanged
|
Contributor
|
It seems fine, motivation wise. Just to be sure, is this label announced to screen readers only when the button is in icon-only mode? |
Contributor
Author
|
My motivation is the new list view being explored in #74120 (it shows "button", "button", "button" as children even when the buttons have some nice content, it doesn't feel ideal) |
jasmussen
approved these changes
Dec 22, 2025
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
A tentative 👍 👍, and I'd encourage others to chime in as well.
SirLouen
added a commit
to SirLouen/gutenberg
that referenced
this pull request
Dec 22, 2025
SirLouen
previously requested changes
Dec 22, 2025
Member
SirLouen
left a comment
SirLouen
left a comment
There was a problem hiding this comment.
@youknowriad if you try these unit tests in #74175 you may notice that they fail, in case of attributes are null or undefined this might return an error.
For the rest, test a couple of extra cases that seem to be passing well.
Contributor
Author
|
Why would the function be called with |
Contributor
Author
|
Feel free to push the other tests here :) |
Member
If It will return PS: Changed base of #74175 |
SirLouen
added a commit
to SirLouen/gutenberg
that referenced
this pull request
Dec 22, 2025
talldan
approved these changes
Dec 23, 2025
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Thsi works well, thanks for addressing the feedback on the other PR.
I guess I leave it up to you whether you want to make it more defensive before merging. Looks like some of the other instances of __experimentalLabel also destructure attributes, and I've not seen any bug reports.
Contributor
Author
|
I'm not a big fan of defensive coding in general, I feel like it's better to address issues at the root. In this case, if the assumption of the The other thing is that I do agree however that there's an issue with whenever |
Contributor
Author
|
This is one place where moving to TS is actually the right path forward, it will help us ensure all the assumptions are actually codified. |
Mamaduka
reviewed
Dec 23, 2025
t-hamano
reviewed
Dec 23, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
What about displaying content only in the list-view context, like the Heading or Details block?
Also, we should only use content as a label when there is content other than spaces, otherwise, the label may appear visually empty:
Contributor
Author
Why did we do that? and not update it consistently in all contexts do you know? |
Contributor
Author
Makes sense indeed. |
Contributor
I don't remember, but at least the label for the block toolbar button seem unnatural without taking the context into account: 
More recently, I've been considering adding a new |
youknowriad
dismissed
SirLouen’s stale review
For consistency with other blocks, I'm not addressing the null/undefined case.
Mamaduka
approved these changes
Dec 23, 2025
youknowriad
force-pushed
the
update/button-block-label
branch
from
8281e8e to
146ae80
Compare
|
Flaky tests detected in 146ae80. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20459299663
|
SirLouen
added a commit
to SirLouen/gutenberg
that referenced
this pull request
Dec 23, 2025
SirLouen
added a commit
to SirLouen/gutenberg
that referenced
this pull request
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Button block to use a label based on its content.
The need for this is more visible in #74120
Testing instructions