Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
102d602
Adds empty bookmark tests.
Apr 7, 2021
a93df37
Adds tests when given bookmark instance.
Apr 7, 2021
dab9e40
Refactored to reduce params init and formatting expected data.
Apr 7, 2021
ae4c802
Speed up the test setup/teardown.
Apr 8, 2021
19a6c5e
Split out the data provider for the groups of tests.
Apr 8, 2021
58013e7
Improves the init_func_params for overriding the bookmark.
Apr 8, 2021
080cc85
Change param to arg to better match PHP docs.
Apr 8, 2021
bb83aee
Adds unhappy path to empty bookmark tests.
Apr 8, 2021
1d3f012
Adds unhappy path test cases to bookmark instance tests.
Apr 8, 2021
f97b83a
Adds @covers.
Apr 8, 2021
90b7062
Adds else path when global link is set and its link_id matches given …
Apr 8, 2021
3d2851d
Adds Path 4 - test pulling from cache when existing link ID given.
Apr 8, 2021
e365e5d
Adds Path 5 tests - pulls existing record from db.
Apr 8, 2021
fd71f83
Adds Path 6 - requested link ID does not exist in db.
Apr 8, 2021
0710645
Improves documentation and consistency.
Apr 8, 2021
9a50500
Rearranges the else branch tests to follow logic flow.
Apr 8, 2021
87caec6
Combines path 2 tests for consistency.
Apr 8, 2021
a4a6ded
Create bookmark in setUp to avoid downstream conflicts.
Apr 8, 2021
c50aeb9
Removes is numeric assertion.
Apr 8, 2021
3111683
Removes deleting bookmark from cache during tearDown.
Apr 23, 2021
6b340f0
Fixes multiline comments and removes empty line in DocBlock.
Apr 23, 2021
829df40
Create and delete bookmark using wp static methods.
Apr 23, 2021
263f7cc
Use custom WP assertSameSets.
Apr 23, 2021
9fcb19b
Removes changes to package-lock.json from PR.
Apr 25, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improves the init_func_params for overriding the bookmark.
  • Loading branch information
hellofromtonya committed Apr 8, 2021
commit 58013e7c3f8ee393f1d92a81020e8fcfef253576
19 changes: 13 additions & 6 deletions tests/phpunit/tests/bookmark/getBookmark.php
Original file line number Diff line number Diff line change
Expand Up @@ -152,23 +152,30 @@ public function data_when_instance_bookmark() {
}

/**
* Initializes the get_bookmark's function parameters to match the order of the function's signature and
* Initialize the get_bookmark's function parameters to match the order of the function's signature and
* reduce code in the tests.
*
* @param array $params Array of given function parameters.
* @param int|stdClass $bookmark Optional. Bookmark's cache key or instance.
*
* @return array An array of ordered parameter.
* @return array An array of ordered parameters.
*/
private function init_func_params( array $params, $bookmark = null ) {
$defaults = array(
'bookmark' => 0,
// The defaults sets the order to match the function's parameters as well as setting the default values.
$defaults = array(
'bookmark' => self::$bookmark,
'output' => OBJECT,
'filter' => 'raw',
);
$params = array_merge( $defaults, $params );
$params['bookmark'] = is_null( $bookmark ) ? self::$bookmark : $bookmark;
$params = array_merge( $defaults, $params );

// When given a bookmark, use it.
if ( ! is_null( $bookmark ) ) {
$params['bookmark'] = $bookmark;
}

// Strip out the keys. Why? The splat operator (...) does not work with associative arrays,
// except for in PHP 8 where the keys are named arguments.
return array_values( $params );
}

Expand Down