Skip to content

52988: Adds tests for get bookmark #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hellofromtonya wants to merge 24 commits into from
Closed

52988: Adds tests for get bookmark #1180

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
102d602
Adds empty bookmark tests.
Apr 7, 2021
a93df37
Adds tests when given bookmark instance.
Apr 7, 2021
dab9e40
Refactored to reduce params init and formatting expected data.
Apr 7, 2021
ae4c802
Speed up the test setup/teardown.
Apr 8, 2021
19a6c5e
Split out the data provider for the groups of tests.
Apr 8, 2021
58013e7
Improves the init_func_params for overriding the bookmark.
Apr 8, 2021
080cc85
Change param to arg to better match PHP docs.
Apr 8, 2021
bb83aee
Adds unhappy path to empty bookmark tests.
Apr 8, 2021
1d3f012
Adds unhappy path test cases to bookmark instance tests.
Apr 8, 2021
f97b83a
Adds @covers.
Apr 8, 2021
90b7062
Adds else path when global link is set and its link_id matches given …
Apr 8, 2021
3d2851d
Adds Path 4 - test pulling from cache when existing link ID given.
Apr 8, 2021
e365e5d
Adds Path 5 tests - pulls existing record from db.
Apr 8, 2021
fd71f83
Adds Path 6 - requested link ID does not exist in db.
Apr 8, 2021
0710645
Improves documentation and consistency.
Apr 8, 2021
9a50500
Rearranges the else branch tests to follow logic flow.
Apr 8, 2021
87caec6
Combines path 2 tests for consistency.
Apr 8, 2021
a4a6ded
Create bookmark in setUp to avoid downstream conflicts.
Apr 8, 2021
c50aeb9
Removes is numeric assertion.
Apr 8, 2021
3111683
Removes deleting bookmark from cache during tearDown.
Apr 23, 2021
6b340f0
Fixes multiline comments and removes empty line in DocBlock.
Apr 23, 2021
829df40
Create and delete bookmark using wp static methods.
Apr 23, 2021
263f7cc
Use custom WP assertSameSets.
Apr 23, 2021
9fcb19b
Removes changes to package-lock.json from PR.
Apr 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds unhappy path to empty bookmark tests.
  • Loading branch information
hellofromtonya committed Apr 8, 2021
commit bb83aee8d9e2730650080fe53e48992ff34c981c
22 changes: 18 additions & 4 deletions tests/phpunit/tests/bookmark/getBookmark.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function tearDown() {
* @dataProvider data_when_empty_bookmark
*/
public function test_should_return_null( $args ) {
$args = $this->init_func_args( $args, 0 );
$args = $this->init_func_args( $args, 0 );
$actual_bookmark = get_bookmark( ...$args );

$this->assertArrayNotHasKey( 'link', $GLOBALS );
Expand All @@ -53,7 +53,7 @@ public function test_should_return_null( $args ) {
*/
public function test_should_return_global_link_in_requested_output_format( $args ) {
$GLOBALS['link'] = self::$bookmark;
$args = $this->init_func_args( $args, 0 );
$args = $this->init_func_args( $args, 0 );
$actual_bookmark = get_bookmark( ...$args );

$expected = $this->maybe_format_expected_data( $args, $GLOBALS['link'] );
Expand All @@ -66,11 +66,25 @@ public function test_should_return_global_link_in_requested_output_format( $args

public function data_when_empty_bookmark() {
return array(
'unhappy path with null bookmark' => array(
// Unhappy path.
'with bookmark type mismatch' => array(
array(
'bookmark' => '',
),
),
'with invalid output' => array(
array(
'bookmark' => 0,
'output' => 'invalid',
),
),
'with bookmark type mismatch and invalid output' => array(
array(
'bookmark' => null,
'output' => 'invalid',
),
),
// Happy path.
'with defaults' => array(
array(
'bookmark' => 0,
Expand Down Expand Up @@ -167,7 +181,7 @@ private function init_func_args( array $args, $bookmark = null ) {
'output' => OBJECT,
'filter' => 'raw',
);
$args = array_merge( $defaults, $args );
$args = array_merge( $defaults, $args );

// When given a bookmark, use it.
if ( ! is_null( $bookmark ) ) {
Expand Down