Skip to content

Don't show block themes in Customizer. #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anton-vlasenko wants to merge 13 commits into from
Closed

Don't show block themes in Customizer. #1991

anton-vlasenko wants to merge 13 commits into from

Conversation

@anton-vlasenko
Copy link

@anton-vlasenko anton-vlasenko commented Dec 1, 2021

Trac ticket: https://core.trac.wordpress.org/ticket/54549

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@anton-vlasenko anton-vlasenko marked this pull request as ready for review December 3, 2021 20:13
@anton-vlasenko anton-vlasenko force-pushed the fix/dont-show-block-themes-in-customizer branch from c6bb399 to e25f91c Compare December 6, 2021 14:55
@anton-vlasenko
Copy link
Author

anton-vlasenko commented Dec 6, 2021

This PR has a lot of changes because it has been rebased on top of #2014 branch (because we've renamed some methods).

@hellofromtonya
Copy link
Contributor

hellofromtonya commented Dec 7, 2021

Hey @anton-vlasenko, I think you need to revert some of the commits in this PR such as 450c03d, ed79860, and 09d4062. All of these were committed today. Then rebase on top of trunk to pull the latest into this PR. Thanks!

@anton-vlasenko anton-vlasenko force-pushed the fix/dont-show-block-themes-in-customizer branch from e25f91c to 60cf94a Compare December 7, 2021 10:33
@anton-vlasenko
Copy link
Author

anton-vlasenko commented Dec 7, 2021 •
edited
Loading

@hellofromtonya Thank you for the review!
Yes, that's a good point. I've made the requested changes (I thought the PR would "update" itself once we merge #2014 into trunk), but it didn't happen).

hellofromtonya
hellofromtonya reviewed Dec 7, 2021
View reviewed changes
@anton-vlasenko anton-vlasenko force-pushed the fix/dont-show-block-themes-in-customizer branch from 69b3ef4 to d5d5bd1 Compare December 10, 2021 17:28
@anton-vlasenko anton-vlasenko force-pushed the fix/dont-show-block-themes-in-customizer branch from c38baa1 to bb28dfd Compare December 13, 2021 16:45
costdev
costdev requested changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. Manual test report on the ticket and additional assertions suggested below.

@hellofromtonya @costdev
Adds tests.
9bd48c8 
Co-authored-by: Colin Stewart <[email protected]>
hellofromtonya
hellofromtonya approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great job @anton-vlasenko ⭐ Marking for commit.

costdev
costdev reviewed Dec 13, 2021
View reviewed changes
@hellofromtonya @costdev
Fixes failing test.
afd821b 
Co-authored-by: Colin Stewart <[email protected]>
@hellofromtonya
Copy link
Contributor

hellofromtonya commented Dec 14, 2021

Committed via changeset https://core.trac.wordpress.org/changeset/52371.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellofromtonya hellofromtonya hellofromtonya approved these changes

@costdev costdev costdev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anton-vlasenko @hellofromtonya @costdev