Try to cache the theme json file reading #3401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
commented
Oct 4, 2022
Comment on lines
203
to
204
| $theme_json = apply_filters( 'theme_json_theme', new WP_Theme_JSON_Data( $theme_json_data, 'theme' ) ); | ||
| $theme_json_data = $theme_json->get_data(); |
Contributor
Author
There was a problem hiding this comment.
If we set static::$theme_json_data after these two lines. Then the theme json file does not apply.
cbravobernal
commented
Oct 4, 2022
| static::$theme_json_data = $theme_json_data; | ||
| $theme_json = apply_filters( 'theme_json_theme', new WP_Theme_JSON_Data( $theme_json_data, 'theme' ) ); | ||
| $theme_json_data = $theme_json->get_data(); | ||
| static::$theme = new WP_Theme_JSON( $theme_json_data ); |
Contributor
Author
There was a problem hiding this comment.
We should test it with child themes.
Contributor
Author
|
cc/ @oandregal, would this approach be correct? |
ockham
force-pushed
the
try/fix-cache-block-styles-theme-json
branch
from
00b8099 to
4f69396
Compare
Contributor
|
Rebased. |
ockham
force-pushed
the
try/fix-cache-block-styles-theme-json
branch
from
4f69396 to
e2704ab
Compare
Contributor
|
I think this is working now 🎉 I was about to implement file caching for the parent theme (see #3401 (comment)), but then it occurred to me that we might solve this slightly differently: We can add a single I'll give that a try. |
Contributor
Author
|
#3408 does the work, so we can close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #44619
Testing instructions:
WordPress/gutenberg#44619 (comment)
Not working yet 😢
Trac ticket: https://core.trac.wordpress.org/ticket/56736