Skip to content

Try to cache the theme json file reading #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cbravobernal wants to merge 5 commits into from
Closed

Try to cache the theme json file reading #3401

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2775e75
Try to cache the theme json file reading
cbravobernal Oct 4, 2022
e2704ab
Cache only the theme json
cbravobernal Oct 4, 2022
e686c5f
Whitespace, variable use
ockham Oct 5, 2022
1a65ed2
Small fix
ockham Oct 5, 2022
9665d71
Rename to theme_json_file_data
ockham Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Whitespace, variable use
  • Loading branch information
@ockham
ockham committed Oct 5, 2022
commit e686c5f5c38b260e61d9af85addb95181bad772b
11 changes: 4 additions & 7 deletions src/wp-includes/class-wp-theme-json-resolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ class WP_Theme_JSON_Resolver {
* @var string
* @access private
*/

protected static $theme_json_data = null;

/**
Expand Down Expand Up @@ -186,10 +185,10 @@ public static function get_theme_data( $deprecated = array(), $options = array()
}

$options = wp_parse_args( $options, array( 'with_supports' => true ) );
if ( null === static::$theme_json_data ) {

$theme_json_data = static::read_json_file( static::get_file_path_from_theme( 'theme.json' ) );
$theme_json_data = static::translate( $theme_json_data, wp_get_theme()->get( 'TextDomain' ) );
if ( null === static::$theme_json_data ) {
static::$theme_json_data = static::read_json_file( static::get_file_path_from_theme( 'theme.json' ) );
static::$theme_json_data = static::translate( static::$theme_json_data, wp_get_theme()->get( 'TextDomain' ) );

/**
* Filters the data provided by the theme for global styles & settings.
Expand All @@ -198,9 +197,7 @@ public static function get_theme_data( $deprecated = array(), $options = array()
*
* @param WP_Theme_JSON_Data Class to access and update the underlying data.
*/

static::$theme_json_data = $theme_json_data;
$theme_json = apply_filters( 'theme_json_theme', new WP_Theme_JSON_Data( $theme_json_data, 'theme' ) );
$theme_json = apply_filters( 'theme_json_theme', new WP_Theme_JSON_Data( static::$theme_json_data, 'theme' ) );
$theme_json_data = $theme_json->get_data();
static::$theme = new WP_Theme_JSON( $theme_json_data );
Copy link
Contributor Author

@cbravobernal cbravobernal Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test it with child themes.


Expand Down