trac-57579 null handled for get_admin_page_title #4084
Conversation
|
Hi @zamandevs! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
src/wp-admin/includes/plugin.php
Outdated
| return $title; | ||
| } | ||
|
|
||
| return ''; |
There was a problem hiding this comment.
| return ''; | |
| return $title; |
This should return $title here. Props @SergeyBiryukov
costdev
left a comment
costdev
left a comment
There was a problem hiding this comment.
Thanks for the update @zamandevs! LGTM 👍
|
|
||
| if ( empty( $title ) ) { | ||
| $title = ''; | ||
| return $title; |
There was a problem hiding this comment.
I think we can remove this line as $title is returned three lines after :)
This avoids the following warning on pages where a title is not defined: ``` PHP Deprecated: strip_tags(): Passing null to parameter WordPress#1 ($string) of type string is deprecated in /wp-admin/admin-header.php on line 36 ``` This should not normally happen, but some folks may pass null to `add_submenu_page()` when creating new pages, to hide that page from the admin menu. This may not be the best approach, but it is one that is documented in the codex and used in the wild: https://developer.wordpress.org/reference/functions/add_submenu_page/#comment-445 - Related Core trac ticket: https://core.trac.wordpress.org/ticket/57579 - Related PR: WordPress#4084
3 participants
https://core.trac.wordpress.org/ticket/57579