Skip to content

trac-57579 null handled for get_admin_page_title #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zamandevs wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

trac-57579 null handled for get_admin_page_title #4084

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f880f6e
trac-57579 null handled for get_admin_page_title
zamandevs Feb 16, 2023
8b36409
empty string changes with title var
zamandevs Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/wp-admin/includes/plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2035,7 +2035,12 @@ function get_admin_page_title() {
}
}

return $title;
if ( empty( $title ) ) {
$title = '';
return $title;
Copy link
Contributor

@audrasjb audrasjb Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this line as $title is returned three lines after :)

}

return '';
Copy link
Contributor

@costdev costdev Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return '';
return $title;

This should return $title here. Props @SergeyBiryukov

}

/**
Expand Down