Skip to content

Use persistent caching around _only_ the theme.json files #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
felixarntz wants to merge 10 commits into
base: trunk
Choose a base branch
from
Draft

Use persistent caching around _only_ the theme.json files #5267

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c54d91b
Add persistent caching for theme.json file data and the i18n schema.
felixarntz Sep 20, 2023
fb227c7
Fix typo.
felixarntz Sep 20, 2023
3dae2a4
Merge branch 'trunk' into test/57789-persistently-cache-theme-json-files
felixarntz Nov 13, 2023
a7d99d7
Remove now useless internal cache properties as they are replaced wit…
felixarntz Nov 13, 2023
9e2e707
Fix test accessing now removed property (reset no longer necessary as…
felixarntz Nov 13, 2023
551d4dc
Update since annotations.
felixarntz Nov 13, 2023
40e111a
Fix test to now rely on object cache API.
felixarntz Nov 13, 2023
5d8efc8
Remove useless variable assignment.
felixarntz Nov 13, 2023
bb31313
Fix WPCS.
felixarntz Nov 13, 2023
d990cfa
Fix incorrect indentation.
felixarntz Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test to now rely on object cache API.
  • Loading branch information
@felixarntz
felixarntz committed Nov 13, 2023
commit 40e111af19be4d371ebb1535e8a4c097a7c22ac4
7 changes: 6 additions & 1 deletion tests/phpunit/tests/theme/wpThemeJsonResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,12 @@ public function test_get_theme_data_does_not_parse_theme_json_if_not_present() {
$theme_data = $theme_json_resolver->get_theme_data( array(), array( 'with_supports' => false ) );
$this->assertInstanceOf( 'WP_Theme_JSON', $theme_data, 'Theme data should be an instance of WP_Theme_JSON.' );
$this->assertSame( $empty_theme_json, $theme_data->get_raw_data(), 'Theme data should be empty without theme support.' );
$this->assertNull( $property->getValue(), 'Theme i18n schema should not have been loaded without theme support.' );

// Include an unmodified $wp_version.
require ABSPATH . WPINC . '/version.php';
$cache_group = 'theme_json_files';
$cache_key = "i18n_schema_{$wp_version}";
$this->assertFalse( wp_cache_get( $cache_key, $cache_group ), 'Theme i18n schema should not have been loaded without theme support.' );
}

/**
Expand Down