Skip to content

Use persistent caching around _only_ the theme.json files #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
felixarntz wants to merge 10 commits into
base: trunk
Choose a base branch
from
Draft

Use persistent caching around _only_ the theme.json files #5267

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c54d91b
Add persistent caching for theme.json file data and the i18n schema.
felixarntz Sep 20, 2023
fb227c7
Fix typo.
felixarntz Sep 20, 2023
3dae2a4
Merge branch 'trunk' into test/57789-persistently-cache-theme-json-files
felixarntz Nov 13, 2023
a7d99d7
Remove now useless internal cache properties as they are replaced wit…
felixarntz Nov 13, 2023
9e2e707
Fix test accessing now removed property (reset no longer necessary as…
felixarntz Nov 13, 2023
551d4dc
Update since annotations.
felixarntz Nov 13, 2023
40e111a
Fix test to now rely on object cache API.
felixarntz Nov 13, 2023
5d8efc8
Remove useless variable assignment.
felixarntz Nov 13, 2023
bb31313
Fix WPCS.
felixarntz Nov 13, 2023
d990cfa
Fix incorrect indentation.
felixarntz Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update since annotations.
  • Loading branch information
@felixarntz
felixarntz committed Nov 13, 2023
commit 551d4dcffe4e30231c6ccc988c7280cb1289d27a
4 changes: 2 additions & 2 deletions src/wp-includes/class-wp-theme-json-resolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class WP_Theme_JSON_Resolver {
*
* @since 5.8.0
* @since 6.1.0 Added caching.
* @since 6.4.0 Added persistent caching using object cache.
* @since 6.5.0 Added persistent caching using object cache.
*
* @param string $file_path Path to file. Empty if no file.
* @param string $cache_key Optional. Key to cache the result under. Omitting the parameter results in no caching
Expand Down Expand Up @@ -392,7 +392,7 @@ public static function get_block_data() {
*
* Data will be cached for the theme that the theme.json file belongs to.
*
* @since 6.4.0
* @since 6.5.0
*
* @param WP_Theme $wp_theme Theme instance.
* @return array Raw array of data read from theme.json, or empty array if not readable.
Expand Down