Skip to content

Conversation

@joemcgill
Copy link
Member

@joemcgill joemcgill commented Nov 9, 2023

Trac ticket: https://core.trac.wordpress.org/ticket/59869


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this.
For reference, here is the related section on HelpHub: https://developer.wordpress.org/reference/functions/_register_theme_block_patterns/#changelog

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joemcgill for the PR. LGTM!

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@QAQQL
Copy link

QAQQL commented Dec 15, 2023

I can't open my blog after updating
图片

Fatal error: Uncaught Error: Call to undefined method WP_Theme::get_block_patterns() in D:\1\wp-includes\block-patterns.php:355 Stack trace: #0 D:\1\wp-includes\class-wp-hook.php(310): _register_theme_block_patterns() #1 D:\1\wp-includes\class-wp-hook.php(334): WP_Hook->apply_filters() #2 D:\1\wp-includes\plugin.php(517): WP_Hook->do_action() #3 D:\1\wp-settings.php(632): do_action() #4 D:\1\wp-config.php(92): require_once('D:\1\wp-sett...') #5 D:\1\wp-load.php(50): require_once('D:\1\wp-conf...') #6 D:\1\wp-blog-header.php(13): require_once('D:\1\wp-load...') #7 D:\1\index.php(17): require('D:\1\wp-blog...') #8 {main} thrown in D:\1\wp-includes\block-patterns.php on line 355

@joemcgill
Copy link
Member Author

@joemcgill joemcgill closed this Dec 20, 2023
@joemcgill
Copy link
Member Author

@QAQQL, if you're still experiencing this issue, can you open a new ticket here or add additional details to this related support forum topic?

@joemcgill joemcgill deleted the update/docs-register-theme-block-patterns branch October 11, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants