Fix #41562. #5
Closed
Fix #41562. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pento
pushed a commit
that referenced
this pull request
Jun 12, 2022
…p_user_settings()`. The `wp_user_settings()` function calls the PHP native `setcookie()` function, the fifth parameter of which is the ''optional'' `$domain` parameter which expects a `string`. A parameter being optional, however, does not automatically make it nullable. As of PHP 8.1, passing `null` to a non-nullable PHP native function will generate a deprecation notice. In this case, this function call yielded a `setcookie(): Passing null to parameter #5 ($domain) of type string is deprecated` notice. Changing the `null` to an empty string fixes this without a backward compatibility break. References: * [https://www.php.net/manual/en/function.setcookie.php PHP Manual: setcookie()] * [https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg PHP RFC: Deprecate passing null to non-nullable arguments of internal functions] Follow-up to [29478]. Props ocean90, shenyanzhi, meysamnorouzi, jrf. Fixes #54914. git-svn-id: https://develop.svn.wordpress.org/trunk@53490 602fd350-edb4-49c9-b593-d223f7449a82
azaozz
pushed a commit
to azaozz/wordpress-develop
that referenced
this pull request
Feb 2, 2024
Updates to Plugin Dependencies
BesrourMS
added a commit
to BesrourMS/wordpress-develop
that referenced
this pull request
Aug 6, 2024
This commit addresses a fatal TypeError occurring in widgets.php when merging sidebar widgets. The error was caused by null values being passed to array_merge(), which expects only arrays. Changes made: Replace the problematic array_merge() call with a more robust loop Add explicit checks for array type before merging Implement array_unique() to remove potential duplicates This fix prevents the "Uncaught TypeError: array_merge(): Argument WordPress#5 must be of type array, null given" error, improving stability when handling widget data, especially during theme switching or widget updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.