Skip to content

Conversation

@spacedmonkey
Copy link
Member

Trac ticket:


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Feb 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @jonnynews.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props swissspidy, get_dave.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy
Copy link
Member

For reference, the issue now is this PHP warning when accessing the REST API:

<b>Warning</b>:  Undefined property: Gutenberg_REST_Global_Styles_Revisions_Controller_6_5::$parent_post_type

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@getdave
Copy link
Contributor

getdave commented Feb 13, 2024

Gutenberg_REST_Global_Styles_Revisions_Controller_6_5

I believe possibly because the extended class sets that property access to private

Exploring also in WordPress/gutenberg#58972

@jonnynews
Copy link

This fixes the e2e tests - 95db1e9

Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing with Gutenberg Plugin active as per original bug report I could not reproduce the original error with these changes in this PR.

Reverting those changes manually sees the error re-appear.

I also ended up coming up with much the same fix on Gutenberg repo so I'm fairly confident this is good.

@spacedmonkey
Copy link
Member Author

Now that global controller changes have been reverted, we need a new patch that reapply them. To that end, here is the original PR with a fix applied. Closing this PR in favour of this #6105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants