Fix array_merge error in widgets.php for null sidebar values #7147
Conversation
This commit addresses a fatal TypeError occurring in widgets.php when merging sidebar widgets. The error was caused by null values being passed to array_merge(), which expects only arrays. Changes made: Replace the problematic array_merge() call with a more robust loop Add explicit checks for array type before merging Implement array_unique() to remove potential duplicates This fix prevents the "Uncaught TypeError: array_merge(): Argument WordPress#5 must be of type array, null given" error, improving stability when handling widget data, especially during theme switching or widget updates.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @BesrourMS. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
|
Hi @BesrourMS! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
This commit addresses a fatal TypeError occurring in widgets.php when merging sidebar widgets. The error was caused by null values being passed to array_merge(), which expects only arrays. Changes made:
Replace the problematic array_merge() call with a more robust loop Add explicit checks for array type before merging
Implement array_unique() to remove potential duplicates
This fix prevents the "Uncaught TypeError: array_merge(): Argument #5 must be of type array, null given" error, improving stability when handling widget data, especially during theme switching or widget updates.
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.