Skip to content

Global styles: preload user global styles based on user caps #7681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonjd wants to merge 3 commits into from
Closed

Global styles: preload user global styles based on user caps #7681

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcc4e3a
This PR preloads '/wp/v2/global-styles/' . $global_styles_id with a c…
ramonjd Oct 30, 2024
7886be4
Added explanatory note
ramonjd Oct 31, 2024
62b2f1c
Merge branch 'trunk' into update/global-styles-preload-correct-path-p…
peterwilsoncc Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/wp-admin/edit-form-blocks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ static function ( $classes ) {

$rest_path = rest_get_route_for_post( $post );

$active_theme = get_stylesheet();

$active_theme = get_stylesheet();
$global_styles_endpoint_context = current_user_can( 'edit_theme_options' ) ? 'edit' : 'view';
// Preload common data.
$preload_paths = array(
'/wp/v2/types?context=view',
Expand All @@ -71,7 +71,14 @@ static function ( $classes ) {
'/wp/v2/global-styles/themes/' . $active_theme . '/variations?context=view',
'/wp/v2/themes?context=edit&status=active',
array( '/wp/v2/global-styles/' . WP_Theme_JSON_Resolver::get_user_global_styles_post_id(), 'OPTIONS' ),
'/wp/v2/global-styles/' . WP_Theme_JSON_Resolver::get_user_global_styles_post_id() . '?context=edit',
/*
* Preload the global styles path with the correct context based on user caps.
* NOTE: There is an equivalent conditional check in the client-side code to fetch
* the global styles entity using the appropriate context value.
* See the call to `canUser()`, under `useGlobalStylesUserConfig()` in `packages/edit-site/src/components/use-global-styles-user-config/index.js`.
* Please ensure that the equivalent check is kept in sync with this preload path.
*/
'/wp/v2/global-styles/' . WP_Theme_JSON_Resolver::get_user_global_styles_post_id() . '?context=' . $global_styles_endpoint_context,
);

block_editor_rest_api_preload( $preload_paths, $block_editor_context );
Expand Down
Loading