Skip to content

Conversation

@dboskovic
Copy link
Contributor

The migration may or or may not error, as it has values like $userTable that are not guaranteed to be provided.

The migration may or or may not error, as it has values like `$userTable` that are not guaranteed to be provided.
@dboskovic
Copy link
Contributor Author

Still is a good idea to do this even if the issue causing the migration error is solved in #639

@andrewelkins andrewelkins merged commit d1a0d96 into Zizaco:master Nov 4, 2016
@andrewelkins
Copy link
Collaborator

Thanks

oldFuryBird added a commit to oldFuryBird/entrust that referenced this pull request Apr 4, 2018
Remove the transaction sentence that dose not work in
mysql DDL action.
Change drop() to dropIfExists() function.

Closes Zizaco#678
@oldFuryBird
Copy link

  1. The transaction for manually using of laravel must control over rollbacks and commit.
    DB::beginTransaction();
    try{
  //...
    DB::commit();
    }catch(Exception $e){
  //...
   DB::rollBack();
  }
// or 
 if(condition)DB::commit();
 else DB::rollBack();
  1. Mysql DDL action such as 'create,drop,delete table' will cause an implicit commit.It means
    DDL sql do not commit a transaction.See mysql-dev-refman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants