Skip to content

Wrap migration in a transaction #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2016
Merged

Wrap migration in a transaction #678

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
911995e
Wrap migration in a transaction
dboskovic Oct 15, 2016
f5ed740
remove empty line at beginning of block
dboskovic Oct 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Wrap migration in a transaction 
The migration may or or may not error, as it has values like `$userTable` that are not guaranteed to be provided.
  • Loading branch information
@dboskovic
dboskovic authored Oct 15, 2016
commit 911995e68c969a7e711533356bd5bf94e765f57c
5 changes: 5 additions & 0 deletions src/views/generators/migration.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ class EntrustSetupTables extends Migration
*/
public function up()
{

DB::beginTransaction();

// Create table for storing roles
Schema::create('{{ $rolesTable }}', function (Blueprint $table) {
$table->increments('id');
Expand Down Expand Up @@ -55,6 +58,8 @@ public function up()

$table->primary(['permission_id', 'role_id']);
});

DB::commit();
}

/**
Expand Down