-
Notifications
You must be signed in to change notification settings - Fork 986
Upload Artifact Node 24 support #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the project to use Node.js version 24, upgrading from Node.js 20. The changes include updating the Node.js type definitions and configuring GitHub Actions to run on the newer Node.js runtime.
- Updates
@types/nodedependency from version 18 to version 24 - Configures GitHub Actions to use
node24runtime instead ofnode20
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates Node.js type definitions to match Node 24 |
| merge/action.yml | Configures merge action to run on Node 24 runtime |
| action.yml | Configures main action to run on Node 24 runtime |
WhiteEuphoria
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xxxx
|
xaXa |
DF791021
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
|
It’s the same as the original version |
This comment was marked as spam.
This comment was marked as spam.
- Add 0bsd and blueoak-1.0.0 to allowed licenses - Add reviewed packages for dependencies with non-standard licenses - Enable UTF-8 encoding
- @bufbuild/protobuf: Apache-2.0 (from upstream LICENSE file) - buffers: marked as reviewed (no license in npm) - chainsaw: MIT/X11 (from npm registry)
- Updated @actions/artifact to ^5.0.0 - Updated @actions/core to ^2.0.0 - Regenerated dist files and license cache
Bumps actions/upload-artifact from 5.0.0 to 6.0.0. ## Release notes Sourced from actions/upload-artifact's releases. v6.0.0 v6 - What's new [!IMPORTANT] actions/upload-artifact@v6 now runs on Node.js 24 (runs.using: node24) and requires a minimum Actions Runner version of 2.327.1. If you are using self-hosted runners, ensure they are updated before upgrading. Node.js 24 This release updates the runtime to Node.js 24. v5 had preliminary support for Node.js 24, however this action was by default still running on Node.js 20. Now this action by default will run on Node.js 24. What's Changed Upload Artifact Node 24 support by @salmanmkc in actions/upload-artifact#719 fix: update @actions/artifact for Node.js 24 punycode deprecation by @salmanmkc in actions/upload-artifact#744 prepare release v6.0.0 for Node.js 24 support by @salmanmkc in actions/upload-artifact#745 Full Changelog: actions/upload-artifact@v5.0.0...v6.0.0 ## Commits b7c566a Merge pull request #745 from actions/upload-artifact-v6-release e516bc8 docs: correct description of Node.js 24 support in README ddc45ed docs: update README to correct action name for Node.js 24 support 615b319 chore: release v6.0.0 for Node.js 24 support 017748b Merge pull request #744 from actions/fix-storage-blob 38d4c79 chore: rebuild dist 7d27270 chore: add missing license cache files for @actions/core, @actions/io, and mi 5f643d3 chore: update license files for @actions/artifact@5.0.1 dependencies 1df1684 chore: update package-lock.json with @actions/artifact@5.0.1 b5b1a91 fix: update @actions/artifact to ^5.0.0 for Node.js 24 punycode fix Additional commits viewable in compare view  Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: lfit.gh2gerrit <[email protected]> Change-Id: I5619142488ce0d1c6bb2529c06c51623ddcfafbc GitHub-PR: #31 GitHub-Hash: 136b7bf501628f71
Summary
This PR updates upload-artifact to use Node.js 24 runtime.
Changes
Related PRs
Testing