Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 15, 2025

Bumps actions/upload-artifact from 5 to 6.

Release notes

Sourced from actions/upload-artifact's releases.

v6.0.0

v6 - What's new

[!IMPORTANT] actions/upload-artifact@v6 now runs on Node.js 24 (runs.using: node24) and requires a minimum Actions Runner version of 2.327.1. If you are using self-hosted runners, ensure they are updated before upgrading.

Node.js 24

This release updates the runtime to Node.js 24. v5 had preliminary support for Node.js 24, however this action was by default still running on Node.js 20. Now this action by default will run on Node.js 24.

What's Changed

Full Changelog: actions/upload-artifact@v5.0.0...v6.0.0

Commits
  • b7c566a Merge pull request #745 from actions/upload-artifact-v6-release
  • e516bc8 docs: correct description of Node.js 24 support in README
  • ddc45ed docs: update README to correct action name for Node.js 24 support
  • 615b319 chore: release v6.0.0 for Node.js 24 support
  • 017748b Merge pull request #744 from actions/fix-storage-blob
  • 38d4c79 chore: rebuild dist
  • 7d27270 chore: add missing license cache files for @​actions/core, @​actions/io, and mi...
  • 5f643d3 chore: update license files for @​actions/artifact@​5.0.1 dependencies
  • 1df1684 chore: update package-lock.json with @​actions/artifact@​5.0.1
  • b5b1a91 fix: update @​actions/artifact to ^5.0.0 for Node.js 24 punycode fix
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Resolves #745
Resolves #744
Resolves actions/upload-artifact#719
Resolves actions/upload-artifact#744
Resolves actions/upload-artifact#745

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5 to 6.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v5...v6)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Dec 15, 2025
@dependabot dependabot bot requested a review from a team as a code owner December 15, 2025 04:07
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Dec 15, 2025
@github-actions
Copy link
Contributor

🤖 Claude Code Review

Code Review Analysis

Pull Request Summary

This PR updates the GitHub Actions upload-artifact action from v5 to v6 across three workflow files for different operating systems (Darwin/macOS, Linux, and Windows).


Review Checklist Results

Code Quality

Code follows style guide

  • This PR only modifies GitHub Actions workflow YAML files
  • The changes are straightforward version bumps with no style violations
  • YAML formatting is consistent across all modified files

No commented-out code

  • No commented-out code present in the changes

Meaningful variable names

  • N/A - No new variables introduced

DRY principle followed

  • N/A - Changes are isolated version bumps in separate workflow files
  • Note: There is some repetition across the three workflow files, but this is standard for platform-specific CI/CD workflows

Identify Defects

  • No bugs, logic errors, or edge cases introduced
  • The upgrade from v5 to v6 is a minor version bump that should be backward compatible
  • No security vulnerabilities introduced

⚠️ Project memory configuration

  • No .claude/CLAUDE.md file found in the repository

Testing

Unit tests for new functions

  • N/A - No code changes requiring unit tests

Integration tests for new endpoints

  • N/A - No new endpoints

Edge cases covered

  • N/A - Configuration change only

Test coverage > 80%

  • N/A - No code changes affecting coverage

Documentation

Readme updated if needed

  • No README changes required or made

⚠️ API docs updated

  • N/A - No API changes

⚠️ Inline comments for complex logic

  • N/A - No complex logic added

CHANGELOG.md updated

  • Issue: The CHANGELOG.md was not updated to reflect this dependency upgrade
  • Location: Root directory - CHANGELOG.md should be updated
  • Recommendation: Add an entry documenting the upgrade from actions/upload-artifact@v5 to v6

Markdown files follow CommonMark

  • No markdown files were modified in this PR

Security

No hardcoded credentials

  • No credentials present

Input validation implemented

  • N/A - No input validation needed for this change

Proper error handling

  • N/A - No error handling changes

No sensitive data in logs

  • No sensitive data exposed

No license files (.lic) or AQAAAD strings

  • No license files or suspicious strings detected

Summary

Overall Assessment: ✅ APPROVED with minor recommendations

This is a clean, straightforward dependency update that upgrades the GitHub Actions upload-artifact action from v5 to v6 across three workflow files. The changes are consistent and appear safe.

Required Action:

  • Update CHANGELOG.md to document this dependency upgrade

Files Modified:

  • .github/workflows/go-test-darwin.yaml:81,87
  • .github/workflows/go-test-linux-sqlite.yaml:86,92
  • .github/workflows/go-test-windows.yaml:69,75

Recommendation:

Add a CHANGELOG entry similar to:

## [Unreleased]

### Changed
- Updated GitHub Actions `actions/upload-artifact` from v5 to v6

The PR is otherwise good to merge once the CHANGELOG is updated.

Automated code review analyzing defects and coding standards

@docktermj docktermj self-assigned this Dec 15, 2025
@docktermj docktermj added the blocked Cannot make progress label Dec 15, 2025
@github-actions
Copy link
Contributor

🤖 Claude Code Review

Code Review Analysis

Code Quality

Code follows style guide - This PR only modifies GitHub Actions workflow YAML files to update action versions. No code style issues present.

No commented-out code - Clean changes with no commented code.

Meaningful variable names - N/A for this PR (workflow version bump only).

DRY principle followed - The same change is consistently applied across all three workflow files.

Identify Defects - No defects identified. The change from actions/upload-artifact@v5 to @v6 is a standard dependency update. However, note that actions/upload-artifact@v6 introduces breaking changes:

  • In v6, artifact names must be unique within a workflow run
  • The PR uses the same artifact name pattern across matrix builds which may cause conflicts if the matrix produces multiple runs with the same senzingsdk-version
  • Files affected:
    • .github/workflows/go-test-darwin.yaml:81-84 and 87-91
    • .github/workflows/go-test-linux-sqlite.yaml:86-89 and 92-96
    • .github/workflows/go-test-windows.yaml:68-72 and 75-79

⚠️ Potential Issue: With upload-artifact@v6, artifact names must be unique across the entire workflow run. If multiple matrix combinations produce the same senzingsdk-version, artifact uploads will conflict. Consider appending additional matrix variables (OS, Go version) to artifact names.

Project memory configuration - No .claude/CLAUDE.md file exists in the repository, so this check is N/A.

Testing

Unit tests for new functions - N/A (no new functions).

Integration tests for new endpoints - N/A (no new endpoints).

Edge cases covered - N/A (infrastructure change only).

Test coverage > 80% - N/A (no code changes affecting coverage).

Documentation

Readme updated if needed - Not required for GitHub Actions version bump.

API docs updated - N/A (no API changes).

Inline comments for complex logic - N/A (workflow files).

CHANGELOG.md updated - No CHANGELOG.md update detected for this dependency version bump. Consider documenting this infrastructure change.

Markdown formatting - N/A (no markdown files modified).

Security

No hardcoded credentials - No credentials present.

Input validation implemented - N/A (workflow configuration).

Proper error handling - N/A (workflow uses standard error handling).

No sensitive data in logs - No sensitive data introduced.

No license files or AQAAAD strings - No license files checked in.


Summary

Overall Assessment: ⚠️ APPROVE WITH RECOMMENDATIONS

This PR performs a straightforward dependency update from actions/upload-artifact@v5 to @v6. The changes are consistent and correctly applied.

Critical Recommendation:

  • Artifact naming collision risk: With upload-artifact@v6, artifact names must be globally unique within a workflow run. Current naming pattern cover-${{ matrix.senzingsdk-version }}.out and test-log-${{ matrix.senzingsdk-version }} may conflict if multiple matrix combinations share the same SDK version. Consider updating to include all matrix dimensions: cover-${{ matrix.os }}-${{ matrix.go }}-${{ matrix.senzingsdk-version }}.out

Minor Recommendation:

  • Update CHANGELOG.md to document this infrastructure dependency update.

Automated code review analyzing defects and coding standards

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

🤖 Claude Code Review

⚠️ No file changes detected - skipping code review.

This PR appears to contain only metadata changes (labels, description, etc.).

@docktermj docktermj merged commit b89a6c3 into main Jan 8, 2026
53 of 55 checks passed
@docktermj docktermj deleted the dependabot/github_actions/actions/upload-artifact-6 branch January 8, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Cannot make progress dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants