Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
finishing touch
  • Loading branch information
Daniel Lemire authored and anonrig committed Jan 22, 2025
commit afef3f1ac01fc8eebbdb85a0cff14e46cefa0e5e
1 change: 1 addition & 0 deletions src/implementation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,5 @@ parse_url_pattern_impl(std::variant<std::string_view, url_pattern_init> input,
const url_pattern_options* options,
url_pattern_regex::std_regex_provider&& provider);
} // namespace parser

} // namespace ada
3 changes: 1 addition & 2 deletions src/url_pattern_helpers.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1303,5 +1303,4 @@ std::string generate_pattern_string(
// Return result.
return result;
}

} // namespace ada::url_pattern_helpers
} // namespace ada::url_pattern_helpers
10 changes: 0 additions & 10 deletions tests/wpt_urlpattern_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,6 @@ TEST(wpt_urlpattern_tests, parse_pattern_string_basic_tests) {
ASSERT_TRUE(part_list);
}

TEST(wpt_urlpattern_tests, compile_basic_tests) {
auto provider = ada::url_pattern_regex::std_regex_provider();
auto protocol_component =
ada::url_pattern_component<ada::url_pattern_regex::std_regex_provider>::
compile("*", ada::url_pattern_helpers::canonicalize_protocol,
ada::url_pattern_compile_component_options::DEFAULT,
provider);
ASSERT_TRUE(protocol_component);
}

TEST(wpt_urlpattern_tests, basic_tests) {
auto init = ada::url_pattern_init{};
init.pathname = "/books";
Expand Down