Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor fixes so that it will compile (but not link)
  • Loading branch information
lemire authored and anonrig committed Jan 22, 2025
commit f0cc24c9d2bb819348593e7858f996667eee3aed
2 changes: 1 addition & 1 deletion include/ada/implementation.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ bool can_parse(std::string_view input,
* use ada::url_pattern_regex::std_regex_provider
* @return url_pattern instance
*/
template <class regex_provider, class regex_type>
template <class regex_provider = ada::url_pattern_regex::std_regex_provider, class regex_type = std::regex>
requires url_pattern_regex::derived_from_provider<regex_provider, regex_type>
ada_warn_unused tl::expected<url_pattern<regex_provider, regex_type>, errors>
parse_url_pattern(std::variant<std::string_view, url_pattern_init> input,
Expand Down
5 changes: 2 additions & 3 deletions tests/wpt_urlpattern_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ TEST(wpt_urlpattern_tests, basic_tests) {
// https://github.com/web-platform-tests/wpt/blob/0c1d19546fd4873bb9f4147f0bbf868e7b4f91b7/urlpattern/resources/urlpattern-hasregexpgroups-tests.js
TEST(wpt_urlpattern_tests, has_regexp_groups) {
auto create_init = [](std::string_view component, std::string value)
-> ada::url_pattern_init<ada::url_pattern_regex::std_regex_provider,
std::regex> {
-> ada::url_pattern_init {
if (component == "protocol") return {.protocol = value};
if (component == "username") return {.username = value};
if (component == "password") return {.password = value};
Expand Down Expand Up @@ -229,7 +228,7 @@ parse_pattern_field(ondemand::array& patterns) {
return std::tuple(*init_str, base_url, options);
}

tl::expected<ada::url_pattern<std::regex>, ada::errors> parse_pattern(
tl::expected<ada::url_pattern<ada::url_pattern_regex::std_regex_provider, std::regex>, ada::errors> parse_pattern(
std::variant<std::string, ada::url_pattern_init, bool>& init_variant,
std::optional<std::string>& base_url,
std::optional<ada::url_pattern_options>& options) {
Expand Down