Skip to content

fix: Improve set_port validation #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anonrig merged 18 commits into from
Jan 12, 2025
Merged

fix: Improve set_port validation #839

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
28734ef
fix: Improve set_port validation and get_host behavior
mertcanaltin Jan 7, 2025
262cf79
lint
mertcanaltin Jan 7, 2025
cf1c3a2
properly handle invalid port input with non-digit characters
mertcanaltin Jan 11, 2025
e410616
Merge branch 'main' into mert/fix-set-port-validation-1
mertcanaltin Jan 11, 2025
11310f8
conflict solved
mertcanaltin Jan 11, 2025
0688813
conflict solved
mertcanaltin Jan 11, 2025
03d9cf9
add early return for non-digit input in `set_port`
mertcanaltin Jan 11, 2025
886c241
Update src/url.cpp
mertcanaltin Jan 12, 2025
63c720a
Update src/url.cpp
mertcanaltin Jan 12, 2025
45b5d5d
Update src/url_aggregator.cpp
mertcanaltin Jan 12, 2025
cd2657e
Update src/url_aggregator.cpp
mertcanaltin Jan 12, 2025
2133171
Update tests/basic_tests.cpp
mertcanaltin Jan 12, 2025
5bb0bde
Update tests/basic_tests.cpp
anonrig Jan 12, 2025
d799ba0
Update src/url_aggregator.cpp
anonrig Jan 12, 2025
588f38f
Update src/url.cpp
anonrig Jan 12, 2025
0bd9914
Update src/url.cpp
anonrig Jan 12, 2025
a04a2bd
Update src/url_aggregator.cpp
anonrig Jan 12, 2025
2a96a14
Update tests/basic_tests.cpp
anonrig Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update tests/basic_tests.cpp
  • Loading branch information
@anonrig
anonrig authored Jan 12, 2025
commit 2a96a140d8887e9ed44257cde34f34af9c75029c
2 changes: 1 addition & 1 deletion tests/basic_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ TYPED_TEST(basic_tests, set_invalid_port) {
ASSERT_TRUE(url);
ASSERT_FALSE(url->set_port("invalid80"));
ASSERT_EQ(url->get_port(), "");
ASSERT_FALSE(url->set_port("80valid"));
ASSERT_TRUE(url->set_port("80valid"));
ASSERT_TRUE(url->is_valid);
ASSERT_EQ(url->get_port(), "80");
ASSERT_TRUE(url->is_valid);
Expand Down
Loading