-
-
Notifications
You must be signed in to change notification settings - Fork 115
fix: Improve set_port validation #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
anonrig
merged 18 commits into
ada-url:main
from
mertcanaltin:mert/fix-set-port-validation-1
Jan 12, 2025
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
28734ef
fix: Improve set_port validation and get_host behavior
mertcanaltin 262cf79
lint
mertcanaltin cf1c3a2
properly handle invalid port input with non-digit characters
mertcanaltin e410616
Merge branch 'main' into mert/fix-set-port-validation-1
mertcanaltin 11310f8
conflict solved
mertcanaltin 0688813
conflict solved
mertcanaltin 03d9cf9
add early return for non-digit input in `set_port`
mertcanaltin 886c241
Update src/url.cpp
mertcanaltin 63c720a
Update src/url.cpp
mertcanaltin 45b5d5d
Update src/url_aggregator.cpp
mertcanaltin cd2657e
Update src/url_aggregator.cpp
mertcanaltin 2133171
Update tests/basic_tests.cpp
mertcanaltin 5bb0bde
Update tests/basic_tests.cpp
anonrig d799ba0
Update src/url_aggregator.cpp
anonrig 588f38f
Update src/url.cpp
anonrig 0bd9914
Update src/url.cpp
anonrig a04a2bd
Update src/url_aggregator.cpp
anonrig 2a96a14
Update tests/basic_tests.cpp
anonrig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
properly handle invalid port input with non-digit characters
- Loading branch information
commit cf1c3a2d25dd4319b22c02229cfbb596fd39a830
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.