Remove unused variable. #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
reviewed
Jan 9, 2020
| if ( isInISR() ) | ||
| { | ||
| BaseType_t ret, xHigherPriorityTaskWoken = pdFALSE; | ||
| BaseType_t xHigherPriorityTaskWoken = pdFALSE; |
Member
There was a problem hiding this comment.
worse issue, this shadow the outter ret variable, thank you very much. This needs an eagle eye to catch :)
Collaborator
Author
There was a problem hiding this comment.
No eagle eye required -- just build with all warnings enabled. It's even an option exposed in the UI. :)
However, it appears that the move away from the Travis builds lost the ability to find regressions related to warning levels. Now, warnings are ignored by the GitHub action based builds. (This may be how it slipped past?)
Member
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for build warning