Skip to content

Remove unused variable. #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hathach merged 1 commit into from
Jan 9, 2020
Merged

Remove unused variable. #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cores/nRF5/utility/SoftwareTimer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ bool SoftwareTimer::start(void)
bool ret = true;
if ( isInISR() )
{
BaseType_t ret, xHigherPriorityTaskWoken = pdFALSE;
BaseType_t xHigherPriorityTaskWoken = pdFALSE;
Copy link
Member

@hathach hathach Jan 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worse issue, this shadow the outter ret variable, thank you very much. This needs an eagle eye to catch :)

Copy link
Collaborator Author

@henrygab henrygab Jan 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No eagle eye required -- just build with all warnings enabled. It's even an option exposed in the UI. :)

However, it appears that the move away from the Travis builds lost the ability to find regressions related to warning levels. Now, warnings are ignored by the GitHub action based builds. (This may be how it slipped past?)

ret = (pdPASS == xTimerStartFromISR(_handle, &xHigherPriorityTaskWoken));
portYIELD_FROM_ISR(xHigherPriorityTaskWoken);
}else
Expand Down