Skip to content

Conversation

@outlandnish
Copy link
Contributor

@outlandnish outlandnish commented Feb 5, 2020

Adds boards.txt info for flashing Xenon from Arduino IDE
Fixes pin mappings for digital pins
Can now control RGB LED and Primary LED with HardwarePWM and analogWrite()

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these all xenon-specific functions, user should be able to do that in user sketch.

@outlandnish
Copy link
Contributor Author

As mentioned in the changes, the primary and RGB leds now work with analogWrite and HardwarePWM

@outlandnish
Copy link
Contributor Author

Added the Adafruit bootloader for the Particle Xenon to the bootloader folder to facilitate builds

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the huge progress so far, there is only a minor thing left to remove NRF52 macro, and check if SPI/WIRE pin mapping is correct. We can merge this after these changes.

…efinitions for RTS and CTS for Serial1 and Serial2
@outlandnish
Copy link
Contributor Author

@hathach @jaswope @DirtyEngineer thanks for pointing me in the right direction! Up until now I had changed just enough to get it to work for me but this helps a lot having it work properly.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb! Thank you very much for your effort so far. I am sure people will find this PR helpful

@jaswope
Copy link
Contributor

jaswope commented Feb 8, 2020

Thanks for getting this off the ground. With Particle discontinuing support for the board, this is much needed. Please check out outlandnish#1 for a few more changes that I thought would be appropriate for this merge.

@outlandnish
Copy link
Contributor Author

@jaswope yeah it's a bit sad that Particle is ending support (it's such a cheap and solid variant!) but it's really awesome they made as much of the documentation public as they did. That's what's really enabled any of this.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove xenon from ci

@DirtyEngineer
Copy link

Just a question, Line 45 of variant.h
#define NUM_ANALOG_OUTPUTS (6)

Should this not be "0" like all of the other nRF52840 boards?

@outlandnish
Copy link
Contributor Author

Just a question, Line 45 of variant.h
#define NUM_ANALOG_OUTPUTS (6)

Should this not be "0" like all of the other nRF52840 boards?

@DirtyEngineer Are PWM outputs not considered analog outputs? If not, I can set that to 0.

@DirtyEngineer
Copy link

DirtyEngineer commented Feb 8, 2020

@outlandnish It's my understanding that a true analog output would be from a DAC which to my knowledge the nRF52840 doesn't have. I think that the analog output field is legacy from the SAMD port which those chips do have a DAC. Anyone else have input on this?

@jaswope
Copy link
Contributor

jaswope commented Feb 9, 2020

I've been cribbing off of the Feather nRF52840 Express variant for much of this, and it has 0 for the number of analog output pins as well. My bet is this is the same.

@jaswope
Copy link
Contributor

jaswope commented Feb 9, 2020

In case it comes up: I defined the external flash device as a MX25L3233F (4MB flash), and I believe that to be correct. There's some differing information about which chip it uses when researching it, with some places saying it only has the 2MB MX25L1606 instead.

The reason I think the 4MB chip is correct is due to this blog post (which mentions the upgrade) and the datasheets included in the Xenon repo. I think the other chip is the initial design that was never shipped.

@outlandnish
Copy link
Contributor Author

Sounds good, updated

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb! Look great now, thank you very much everyone for working together on this PR.

@hathach hathach merged commit e932935 into adafruit:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants