Skip to content

Conversation

@jaswope
Copy link

@jaswope jaswope commented Feb 8, 2020

Thanks for all the work you already put in on this! This PR addresses the following issues:

  • Modified the variant definition so that all the examples will compile (basing the changes on choices made by other variants)
    • Defined the VBAT and AREF pins (A6 and A7)
    • Defined LED_RED and LED_BLUE, assigned them both to the onboard blue LED (same as done in other variants with only one status LED)
    • Defined LED_CONN
    • Changed LED_BUILTIN to a define to match other variants
  • Added the variant to the github workflow
  • DRY'd up the pin definitions to be more in line with other variants
  • Used the correct Flash SPI device definition

Copy link
Owner

@outlandnish outlandnish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yeah these are definitely needed. I haven't really followed best engineering practices through this process so I really appreciate you taking the time to clean it up a bit more!

@outlandnish outlandnish merged commit d5e1089 into outlandnish:master Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants