Update platform.txt #472
Merged
Update platform.txt #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As recommended
hathach
reviewed
Mar 23, 2020
platform.txt
Outdated
| recipe.size.pattern="{compiler.path}{compiler.size.cmd}" -A "{build.path}/{build.project_name}.elf" | ||
| recipe.size.regex=\.text\s+([0-9]+).* | ||
| recipe.size.regex.data=(\.data|\.bss|\.stack)\s+([0-9]+).* | ||
| recipe.size.regex=^(\.text|.\data)\s+([0-9]+).* |
Member
There was a problem hiding this comment.
sorry I would have said clearly that the regex should be like the https://github.com/arduino/ArduinoCore-samd/blob/master/platform.txt#L120 which is
recipe.size.regex=^(?:\.text|\.data|)\s+([0-9]+).*
recipe.size.regex.data=^(?:\.data|\.bss)\s+([0-9]+).*
You don't have to close the PR, just keep commit and pushing to your patch-5 branch, it will update the PR as well. Sorry for any inconveniences.
hathach
approved these changes
Mar 23, 2020
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
great work, thank you for the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended