Skip to content

Update platform.txt #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hathach merged 2 commits into from
Mar 23, 2020
Merged

Update platform.txt #472

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43d723a
Update platform.txt
toxynoid Mar 23, 2020
1f97330
Update platform.txt
toxynoid Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions platform.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ recipe.output.save_file_hexu={build.project_name}.save.hex

## Compute size
recipe.size.pattern="{compiler.path}{compiler.size.cmd}" -A "{build.path}/{build.project_name}.elf"
recipe.size.regex=\.text\s+([0-9]+).*
recipe.size.regex.data=(\.data|\.bss|\.stack)\s+([0-9]+).*
recipe.size.regex=^(\.text|.\data)\s+([0-9]+).*
Copy link
Member

@hathach hathach Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I would have said clearly that the regex should be like the https://github.com/arduino/ArduinoCore-samd/blob/master/platform.txt#L120 which is

recipe.size.regex=^(?:\.text|\.data|)\s+([0-9]+).*
recipe.size.regex.data=^(?:\.data|\.bss)\s+([0-9]+).*

You don't have to close the PR, just keep commit and pushing to your patch-5 branch, it will update the PR as well. Sorry for any inconveniences.

recipe.size.regex.data=^(\.data|\.bss)\s+([0-9]+).*

## Export Compiled Binary
recipe.output.tmp_file={build.project_name}.hex
Expand Down