Skip to content

fix: resources naming #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
biswapanda wants to merge 7 commits into from
Closed

fix: resources naming #1318

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
50971b7
chore: update dynamo and nixl versions for 0.3.0 (#1240)
nv-anants May 29, 2025
0f94797
fix: cherry-pick of attributions from 0.2.1 release branch (#1267)
saturley-hall May 29, 2025
d78e394
chore: remove sglang hash in pyproject (#1282)
ishandhanani May 30, 2025
3447e31
fix: Only check model name on etcd-registered endpoints (#1283)
jthomson04 May 30, 2025
799748b
fix: service args and operator fixes (#1297)
biswapanda May 30, 2025
cf10bb3
fix: Fix mypy errors on trtllm examples (#1277) (#1306)
tanmayv25 May 30, 2025
0e550d6
fix: copy workspace as part of ci-min stage (#1291) (#1301)
nv-anants May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: copy workspace as part of ci-min stage (#1291) (#1301)
  • Loading branch information
@nv-anants
nv-anants authored May 30, 2025
commit 0e550d68dacddf1c669aae9c16726f3fe34288fa
5 changes: 3 additions & 2 deletions container/Dockerfile.sglang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,9 @@ COPY --from=wheel_builder /opt/nvidia/nvda_nixl /opt/nvidia/nvda_nixl
# Copy Cargo cache to avoid re-downloading dependencies
COPY --from=wheel_builder $CARGO_HOME $CARGO_HOME

# Copy rest of the code
COPY . /workspace

# Build C bindings, creates lib/bindings/c/include
RUN cd /workspace/lib/bindings/c && cargo build --release --locked

Expand Down Expand Up @@ -365,8 +368,6 @@ ARG GENAI_PERF_VERSION
# Install genai-perf for benchmarking
RUN uv pip install genai-perf==$GENAI_PERF_VERSION

COPY . /workspace

ENTRYPOINT ["/opt/nvidia/nvidia_entrypoint.sh"]

CMD []
Expand Down
3 changes: 3 additions & 0 deletions container/Dockerfile.tensorrt_llm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,9 @@ COPY --from=wheel_builder /workspace /workspace
# Copy Cargo cache to avoid re-downloading dependencies
COPY --from=wheel_builder $CARGO_HOME $CARGO_HOME

# Copy rest of the code
COPY . /workspace

# Build C bindings, creates lib/bindings/c/include
RUN cd /workspace/lib/bindings/c && cargo build --release --locked

Expand Down
5 changes: 3 additions & 2 deletions container/Dockerfile.vllm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,9 @@ COPY --from=wheel_builder /opt/nvidia/nvda_nixl /opt/nvidia/nvda_nixl
# Copy Cargo cache to avoid re-downloading dependencies
COPY --from=wheel_builder $CARGO_HOME $CARGO_HOME

# Copy rest of the code
COPY . /workspace

# Build C bindings, creates lib/bindings/c/include
#
# TODO: In theory the 'cargo build' in earlier stage covers this, we "just" need to copy the
Expand Down Expand Up @@ -447,8 +450,6 @@ ARG GENAI_PERF_VERSION
# Install genai-perf for benchmarking
RUN uv pip install genai-perf==$GENAI_PERF_VERSION

COPY . /workspace

ENTRYPOINT ["/opt/nvidia/nvidia_entrypoint.sh"]

CMD []
Expand Down
Loading