fix: Fix NIXL 0.3.1 build

[jthomson04]

Fixes a issue that kept nixl-sys pinned at 0.3.0, even though we're using NIXL 0.3.1. See #1517 (comment)

Summary by CodeRabbit

• Chores

  • Updated an internal dependency to use a specific Git commit for improved consistency.

• Refactor

  • Adjusted initialization parameters for transfer descriptor lists to enhance internal behavior.

[coderabbitai]

Walkthrough

The changes update the nixl-sys dependency in the Cargo manifest to point to a specific Git commit instead of a versioned release, and adjust the initialization of XferDescList in the Rust source code to include an additional boolean argument. No public interfaces or exported entities were modified.

Changes

File(s)	Change Summary
lib/llm/Cargo.toml	Changed nixl-sys dependency from a versioned crate to a Git repository with a specific commit hash.
lib/llm/src/block_manager/block/transfer/nixl.rs	Modified XferDescList::new calls to include an extra boolean argument (true).

Poem

A hop to a Git hash, precise and neat,
And a boolean flag makes new lists complete.
With every commit, dependencies dance,
While transfer lists gain a fresh advance.
In the warren of code, changes align—
Another day’s work, simply divine!
🐇✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

lib/llm/src/block_manager/block/transfer/nixl.rs (2)

140-155: Unnecessary double boxing – drop Box::pin for a leaner future

Box::new(Box::pin(async move { … })) allocates twice and returns
Box<Pin<Box<_>>>, which is larger than needed.
Because the returned trait object is required to be Unpin, you can
simply box the async block – it is Unpin by default.

-        Ok(Box::new(Box::pin(async move {
+        Ok(Box::new(async move {
             let nixl_agent = nixl_agent_arc
                 .as_ref()
                 .as_ref()
                 .expect("NIXL agent not found");
@@
             }
-        })))
+        }))

This removes one heap allocation and clarifies the intent.

---

146-150: Busy-wait loop: expose poll interval

A hard-coded 5 ms sleep is easy to forget and might be sub-optimal on
different hardware. Consider:

const POLL_INTERVAL: Duration = Duration::from_millis(5);
…
tokio::time::sleep(POLL_INTERVAL).await;

or making it configurable via TransferContext.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44c5be7 and 49ea79e.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

• lib/llm/Cargo.toml (1 hunks)
• lib/llm/src/block_manager/block/transfer/nixl.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: Mirror Repository to GitLab
• GitHub Check: pre-merge-rust (lib/runtime/examples)
• GitHub Check: pre-merge-rust (.)
• GitHub Check: pre-merge-rust (lib/bindings/python)
• GitHub Check: Build and Test - vllm

🔇 Additional comments (2)

lib/llm/Cargo.toml (1)

83-85: To ensure the pinned commit truly exists, let’s verify it via GitHub’s API:

#!/usr/bin/env bash
# Check if the specific commit exists in the GitHub repo
status=$(curl -s -o /dev/null -w "%{http_code}" \
  https://api.github.com/repos/ai-dynamo/nixl/commits/a7c654d46a14cd5ce635cc8c02433d71df93dedf)
echo "HTTP status: $status"
if [ "$status" = "200" ]; then
  echo "✅ Commit exists and is reachable."
else
  echo "❌ Commit not found (status $status)."
  exit 1
fi

lib/llm/src/block_manager/block/transfer/nixl.rs (1)

120-122: ```shell
#!/usr/bin/env bash

Search the entire repo for the XferDescList definition and its new implementation

rg --context 5 "struct XferDescList" -n .
rg --context 5 "impl XferDescList" -n .
find . -type f -iname "xfer_desc_list.rs"

</details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

[nv-anants]

Thanks John! After merge, please add a cherry pick PR for release/0.3.1 branch as well

[jthomson04]

@nv-anants Release branch MR opened here: #1571